Conversation
What was broken: Engagement date pickers in assignment, payment, and application modals opened as soon as the modal rendered. Root cause: The modal autofocus landed on react-datepicker inputs, and those pickers were still allowed to open on focus. What was changed: Added a preventOpenOnFocus pass-through on the shared date picker components and enabled it for the engagement modal date fields, including the payment modal's direct date picker. Any added/updated tests: Added regression tests for StartDateTimeInput and PaymentFormModal to verify preventOpenOnFocus is wired through.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken:
Engagement date pickers in assignment, payment, and application modals opened as soon as the modal rendered.
Root cause (if identifiable):
The modal autofocus landed on react-datepicker inputs, and those pickers were still allowed to open on focus.
What was changed:
Added a preventOpenOnFocus pass-through on the shared date picker components and enabled it for the engagement modal date fields, including the payment modal's direct date picker.
Any added/updated tests:
Added regression tests for StartDateTimeInput and PaymentFormModal to verify preventOpenOnFocus is wired through.