Conversation
What was broken\nDesign challenge creation allowed the New action to succeed without a selected work type.\n\nRoot cause\nThe createNewChallenge flow validated only the basic fields it triggered and skipped workType even when the Design + Challenge selection made it mandatory.\n\nWhat was changed\nAdded a create-path validation guard for workType that uses the same Design + Challenge visibility condition as the UI before calling createChallenge.\nDocumented the new helper functions used by the create flow.\n\nAny added/updated tests\nUpdated ChallengeEditorForm.spec.tsx with a regression test that blocks design challenge creation when work type is missing.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken\nDesign challenge creation allowed the New action to succeed without a selected work type.\n\nRoot cause\nThe createNewChallenge flow validated only the basic fields it triggered and skipped workType even when the Design + Challenge selection made it mandatory.\n\nWhat was changed\nAdded a create-path validation guard for workType that uses the same Design + Challenge visibility condition as the UI before calling createChallenge.\nDocumented the new helper functions used by the create flow.\n\nAny added/updated tests\nUpdated ChallengeEditorForm.spec.tsx with a regression test that blocks design challenge creation when work type is missing.