Conversation
What was broken Opening an invited project from the Work Manager projects list always routed users to the project challenges page, so the join/decline invitation modal did not appear. Root cause Project list navigation always used the default challenges path and never checked whether the current user was only a pending invitee for that project. What was changed Added an invite-aware project landing path helper that reuses the existing invite ownership matcher, and updated the projects table/card links to send invited users to /projects/:projectId/invitations instead of /projects/:projectId/challenges. Any added/updated tests Added navigation.utils.spec.ts coverage for invited-user and non-invited-user project landing paths, and kept the related permissions utils tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Opening an invited project from the Work Manager projects list always routed users to the project challenges page, so the join/decline invitation modal did not appear.
Root cause
Project list navigation always used the default challenges path and never checked whether the current user was only a pending invitee for that project.
What was changed
Added an invite-aware project landing path helper that reuses the existing invite ownership matcher, and updated the projects table/card links to send invited users to /projects/:projectId/invitations instead of /projects/:projectId/challenges.
Any added/updated tests
Added navigation.utils.spec.ts coverage for invited-user and non-invited-user project landing paths, and kept the related permissions utils tests passing.