Skip to content

PM-4642: Filter manual reviewer phase options#1577

Merged
jmgasper merged 2 commits intodevfrom
PM-4642
Apr 1, 2026
Merged

PM-4642: Filter manual reviewer phase options#1577
jmgasper merged 2 commits intodevfrom
PM-4642

Conversation

@jmgasper
Copy link
Copy Markdown
Collaborator

@jmgasper jmgasper commented Apr 1, 2026

What was broken
Manual reviewer phase dropdowns showed every challenge phase, including registration/submission and phases that were already assigned on other manual reviewer cards.

Root cause
HumanReviewTab built a single shared phase option list directly from the raw challenge phases and reused it for every reviewer row, so the options were never filtered per card.

What was changed
Computed reviewer phase options per manual reviewer row, preserving the current selection while hiding registration/submission-style phases and phases already assigned on other manual reviewer cards. Updated the Challenge Editor README to reflect the reviewer phase selector behavior.

Any added/updated tests
Added a HumanReviewTab spec that verifies each reviewer card only receives unassigned non-submission phases in its dropdown options.


Open with Devin

What was broken
Manual reviewer phase dropdowns showed every challenge phase, including registration/submission and phases that were already assigned on other manual reviewer cards.

Root cause
HumanReviewTab built a single shared phase option list directly from the raw challenge phases and reused it for every reviewer row, so the options were never filtered per card.

What was changed
Computed reviewer phase options per manual reviewer row, preserving the current selection while hiding registration/submission-style phases and phases already assigned on other manual reviewer cards. Updated the Challenge Editor README to reflect the reviewer phase selector behavior.

Any added/updated tests
Added a HumanReviewTab spec that verifies each reviewer card only receives unassigned non-submission phases in its dropdown options.
@jmgasper jmgasper requested a review from kkartunov as a code owner April 1, 2026 14:12
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@jmgasper jmgasper merged commit 7ece71a into dev Apr 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant