Conversation
What was broken Manual reviewer phase dropdowns showed every challenge phase, including registration/submission and phases that were already assigned on other manual reviewer cards. Root cause HumanReviewTab built a single shared phase option list directly from the raw challenge phases and reused it for every reviewer row, so the options were never filtered per card. What was changed Computed reviewer phase options per manual reviewer row, preserving the current selection while hiding registration/submission-style phases and phases already assigned on other manual reviewer cards. Updated the Challenge Editor README to reflect the reviewer phase selector behavior. Any added/updated tests Added a HumanReviewTab spec that verifies each reviewer card only receives unassigned non-submission phases in its dropdown options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Manual reviewer phase dropdowns showed every challenge phase, including registration/submission and phases that were already assigned on other manual reviewer cards.
Root cause
HumanReviewTab built a single shared phase option list directly from the raw challenge phases and reused it for every reviewer row, so the options were never filtered per card.
What was changed
Computed reviewer phase options per manual reviewer row, preserving the current selection while hiding registration/submission-style phases and phases already assigned on other manual reviewer cards. Updated the Challenge Editor README to reflect the reviewer phase selector behavior.
Any added/updated tests
Added a HumanReviewTab spec that verifies each reviewer card only receives unassigned non-submission phases in its dropdown options.