Conversation
What was broken After creating an engagement from platform-ui, the work app could keep the user on the create flow instead of taking them to the saved engagement details page. Root cause (if identifiable) The create success redirect used a hard-coded /projects/... path and dropped the work app root route prefix when the app was mounted under /work. What was changed Updated the engagement editor create success navigation and cancel link to build their path from the work app root route before appending the project and engagement segments. Any added/updated tests Added a regression test for the create flow to verify the saved engagement redirects to the work app engagement details URL.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
After creating an engagement from platform-ui, the work app could keep the user on the create flow instead of taking them to the saved engagement details page.
Root cause (if identifiable)
The create success redirect used a hard-coded /projects/... path and dropped the work app root route prefix when the app was mounted under /work.
What was changed
Updated the engagement editor create success navigation and cancel link to build their path from the work app root route before appending the project and engagement segments.
Any added/updated tests
Added a regression test for the create flow to verify the saved engagement redirects to the work app engagement details URL.