Conversation
What was broken
- The Work app Engagements list opened /opportunities/:id on the engagements domain, which does not match the deployed detail route and led to a blank page.
Root cause
- EngagementsListPage still built the external View link with a legacy /opportunities prefix instead of the current detail route exposed by the engagements app.
What was changed
- Updated the external engagement View link helper to point directly to /{engagement.id} on the engagements app domain.
- Added a regression test that renders an engagement row and verifies the View href omits /opportunities.
Any added/updated tests
- Updated EngagementsListPage.spec.tsx with a View link href assertion covering this regression.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
/opportunities/:idon the engagements domain, which does not match the deployed detail route and led to a blank page.Root cause
EngagementsListPagestill built the external View link with a legacy/opportunitiesprefix instead of the current detail route exposed by the engagements app.What was changed
${ENGAGEMENTS_APP_URL}/{engagement.id}on the engagements app domain./opportunities.Any added/updated tests
EngagementsListPage.spec.tsxwith a View link href assertion covering this regression.