Skip to content

PM-4634: fix engagement On Hold status filter#1583

Merged
jmgasper merged 1 commit intodevfrom
PM-4634
Apr 1, 2026
Merged

PM-4634: fix engagement On Hold status filter#1583
jmgasper merged 1 commit intodevfrom
PM-4634

Conversation

@jmgasper
Copy link
Copy Markdown
Collaborator

@jmgasper jmgasper commented Apr 1, 2026

What was broken

  • The work app engagement status filter exposed "Pending Assignment" and sent a status value the engagements API rejects, which caused the engagements page error.

Root cause

  • The work app still used a legacy Pending Assignment label and API mapping instead of the current ON_HOLD engagement status expected by the backend.

What was changed

  • Replaced the work app engagement status option with "On Hold".
  • Mapped both "On Hold" and legacy "Pending Assignment" inputs to ON_HOLD for backward compatibility.
  • Normalized ON_HOLD and legacy PENDING_ASSIGNMENT API values to the "On Hold" label.
  • Kept the feedback page notice working for both status labels.

Any added/updated tests

  • Added engagement status mapping regression tests covering the filter label and API conversions.

Open with Devin

What was broken\n- The work app engagement status filter exposed "Pending Assignment" and sent a status value the engagements API rejects, which caused the engagements page error.\n\nRoot cause\n- The work app still used a legacy Pending Assignment label and API mapping instead of the current ON_HOLD engagement status expected by the backend.\n\nWhat was changed\n- Replaced the work app engagement status option with "On Hold".\n- Mapped both "On Hold" and legacy "Pending Assignment" inputs to ON_HOLD for backward compatibility.\n- Normalized ON_HOLD and legacy PENDING_ASSIGNMENT API values to the "On Hold" label.\n- Kept the feedback page notice working for both status labels.\n\nAny added/updated tests\n- Added engagement status mapping regression tests covering the filter label and API conversions.
@jmgasper jmgasper requested a review from kkartunov as a code owner April 1, 2026 15:32
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@jmgasper jmgasper merged commit 330e9ab into dev Apr 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant