Conversation
What was broken The new Work app engagement list omitted the Delete action on both the global engagements page and the project-scoped engagements page, so admins could no longer delete engagements from the list. Root cause The migrated EngagementsListPage only rendered View and Edit actions even though the work app already had a delete service available and the legacy work-manager list exposed an admin-only delete flow. What was changed Added the missing admin-only Delete action to engagement rows, wired it to the existing deleteEngagement service through a confirmation modal, refreshed the list after a successful delete, and surfaced the assigned-members delete conflict message with the existing toast utilities. Also hardened the status-pill helper to safely handle empty status strings. Any added/updated tests Updated EngagementsListPage.spec.tsx to cover admin delete visibility, non-admin manager visibility, and the delete-confirmation success flow.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The new Work app engagement list omitted the Delete action on both the global engagements page and the project-scoped engagements page, so admins could no longer delete engagements from the list.
Root cause
The migrated EngagementsListPage only rendered View and Edit actions even though the work app already had a delete service available and the legacy work-manager list exposed an admin-only delete flow.
What was changed
Added the missing admin-only Delete action to engagement rows, wired it to the existing deleteEngagement service through a confirmation modal, refreshed the list after a successful delete, and surfaced the assigned-members delete conflict message with the existing toast utilities. Also hardened the status-pill helper to safely handle empty status strings.
Any added/updated tests
Updated EngagementsListPage.spec.tsx to cover admin delete visibility, non-admin manager visibility, and the delete-confirmation success flow.