Conversation
What was broken Typing in the Search by name filter on the work engagements page triggered a new engagements fetch on each debounced change, causing the page to keep returning to a loading state while users typed. Root cause The page already filtered engagement titles locally, but it also forwarded the same title value into useFetchEngagements, so SWR treated each input change as a new request key. What was changed Removed title from the request filters passed to useFetchEngagements so the existing local title filter is used without refetching. Added a regression test that updates the name filter and verifies the fetch hook is still called without a title request filter. Any added/updated tests Updated src/apps/work/src/pages/engagements/EngagementsListPage/EngagementsListPage.spec.tsx with a regression test for the name filter fetch behavior.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
# Conflicts: # src/apps/work/src/pages/engagements/EngagementsListPage/EngagementsListPage.spec.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Typing in the Search by name filter on the work engagements page triggered a new engagements fetch on each debounced change, causing the page to keep returning to a loading state while users typed.
Root cause (if identifiable)
The page already filtered engagement titles locally, but it also forwarded the same title value into useFetchEngagements, so SWR treated each input change as a new request key.
What was changed
Any added/updated tests