Conversation
What was broken\nManual iterative review assignments on F2F challenges could reopen with a visible reviewer row but no restored memberId, which triggered member-required validation on later saves and launches.\n\nRoot cause\nHumanReviewTab only mapped the Iterative Review phase to the `Iterative Reviewer` role name. After save/reset dropped the persisted reviewer roleId, the form could not resolve existing resources stored under the `Iterative Review` alias back into reviewer member assignments.\n\nWhat was changed\nHumanReviewTab now resolves iterative review resources using both supported role-name aliases so saved reviewer resources repopulate the member assignment fields.\nA regression test now covers persisted reviewer rows without roleId when the backing resource role is named `Iterative Review`.\n\nAny added/updated tests\nAdded the iterative review alias regression test in HumanReviewTab.spec.tsx.\n
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken\nManual iterative review assignments on F2F challenges could reopen with a visible reviewer row but no restored memberId, which triggered member-required validation on later saves and launches.\n\nRoot cause\nHumanReviewTab only mapped the Iterative Review phase to the
Iterative Reviewerrole name. After save/reset dropped the persisted reviewer roleId, the form could not resolve existing resources stored under theIterative Reviewalias back into reviewer member assignments.\n\nWhat was changed\nHumanReviewTab now resolves iterative review resources using both supported role-name aliases so saved reviewer resources repopulate the member assignment fields.\nA regression test now covers persisted reviewer rows without roleId when the backing resource role is namedIterative Review.\n\nAny added/updated tests\nAdded the iterative review alias regression test in HumanReviewTab.spec.tsx.