Conversation
What was broken Draft challenge pages could keep showing a /usr/bin/bash challenge fee even when the project billing account had markup configured. Root cause When fetched draft data reset the challenge editor form, it reused the raw challenge billing payload and overwrote the already-hydrated project billing markup. Because the project billing data had usually loaded first, the later billing merge effect did not run again to repair that reset. What was changed The challenge editor now applies project billing defaults during the draft reset path as well, using the latest resolved project billing account so stale draft markup does not replace the correct value. Any added/updated tests Added a ChallengeEditorForm regression test that simulates project billing loading before the draft response and verifies the hydrated markup survives the form reset.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Draft challenge pages could keep showing a /usr/bin/bash challenge fee even when the project billing account had markup configured.
Root cause
When fetched draft data reset the challenge editor form, it reused the raw challenge billing payload and overwrote the already-hydrated project billing markup. Because the project billing data had usually loaded first, the later billing merge effect did not run again to repair that reset.
What was changed
The challenge editor now applies project billing defaults during the draft reset path as well, using the latest resolved project billing account so stale draft markup does not replace the correct value.
Any added/updated tests
Added a ChallengeEditorForm regression test that simulates project billing loading before the draft response and verifies the hydrated markup survives the form reset.