Skip to content

PM-4709: restore AI review details in challenge view mode#1630

Merged
jmgasper merged 6 commits intodevfrom
PM-4709
Apr 6, 2026
Merged

PM-4709: restore AI review details in challenge view mode#1630
jmgasper merged 6 commits intodevfrom
PM-4709

Conversation

@jmgasper
Copy link
Copy Markdown
Collaborator

@jmgasper jmgasper commented Apr 3, 2026

What was broken
In the read-only challenge view, the review section lived inside a disabled fieldset.
That made the AI review tab non-interactive and hid AI review details behind the default human tab.
The view also lacked the human and AI review summary shown in work manager.

Root cause
The disabled fieldset wrapped the entire challenge editor, including the review tab switcher.
The new platform-ui review form only rendered editable tab panels and never surfaced a view-only summary.

What was changed
Moved the read-only review section outside the parent disabled fieldset while keeping the review panels inside their own disabled fieldset.
Kept the tab switcher interactive in view mode and added a read-only review configuration summary for human reviewers, AI workflows, review flow, and estimated cost.
Updated the challenge editor docs to describe the read-only review behavior.

Any added/updated tests
Added a ReviewersField read-only tab regression test.
Added ReviewConfigurationSummary coverage for human and AI summary rendering.
Ran yarn test:no-watch --runInBand; unrelated existing failures remain in src/apps/wallet-admin/src/home/tabs/payments/PaymentsListView.spec.tsx.

What was broken
In the read-only challenge view, the review section lived inside a disabled fieldset.
That made the AI review tab non-interactive and hid AI review details behind the default human tab.
The view also lacked the human and AI review summary shown in work manager.

Root cause
The disabled fieldset wrapped the entire challenge editor, including the review tab switcher.
The new platform-ui review form only rendered editable tab panels and never surfaced a view-only summary.

What was changed
Moved the read-only review section outside the parent disabled fieldset while keeping the review panels inside their own disabled fieldset.
Kept the tab switcher interactive in view mode and added a read-only review configuration summary for human reviewers, AI workflows, review flow, and estimated cost.
Updated the challenge editor docs to describe the read-only review behavior.

Any added/updated tests
Added a ReviewersField read-only tab regression test.
Added ReviewConfigurationSummary coverage for human and AI summary rendering.
Ran yarn test:no-watch --runInBand; unrelated existing failures remain in src/apps/wallet-admin/src/home/tabs/payments/PaymentsListView.spec.tsx.
@jmgasper jmgasper requested a review from kkartunov as a code owner April 3, 2026 12:42
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@jmgasper jmgasper merged commit 80889f7 into dev Apr 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant