[codex] PM-4700: refresh project manager create-project fix#1660
Merged
[codex] PM-4700: refresh project manager create-project fix#1660
Conversation
What was broken Project Manager users could open the Projects page, but the New Project action was hidden and the create route redirected them back to the list. Root cause (if identifiable) The shared work-app project permission helper only treated copilots and talent managers as eligible to create projects when no project context was present. What was changed Updated the project management permission helper so Project Manager roles can create new projects while keeping existing project edit access membership-based. Added a Projects list regression test to verify the New Project action renders for Project Manager users. Any added/updated tests Updated permissions.utils.spec.ts to cover Project Manager create access and preserve membership requirements for editing. Added ProjectsListPage.spec.tsx to cover the Projects page header action.
# Conflicts: # src/apps/work/src/lib/utils/permissions.utils.spec.ts # src/apps/work/src/lib/utils/permissions.utils.ts
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Merged the latest
devbranch into this fix branch and kept thePM-4700project-creation permission behavior intact.Project Managers can still create a new project from
/projectsand open/projects/new, while editing an existing project remains limited to manager/copilot project members.Why
The original
PM-4700change was correct, but the branch had fallen well behinddevand its conflict area was the shared project permission helper. This refresh keeps the intended behavior on top of currentdev.Root cause
checkCanManageProject(...)only allowed copilots and Talent Managers to create projects when no project context was present, which hid theNew Projectaction and redirected Project Managers away from the create route.Impact
Users with the
Project Managerrole can see theNew Projectbutton on/projectsand can access the create-project flow again.Validation
yarn test:no-watch --runTestsByPath src/apps/work/src/lib/utils/permissions.utils.spec.ts src/apps/work/src/pages/projects/ProjectsListPage/ProjectsListPage.spec.tsxyarn lintyarn run build(build succeeds; existing repo warnings from mergeddevremain)Notes
This draft PR is opened from
codex/pm-4700-refreshbecausePM-4700already has an open PR todev(#1639).