Conversation
What was broken Edit challenge saves reported success even when a phase end date had been changed, but the updated end date was missing after reload because the save request omitted it. Root cause (if identifiable) The challenge editor serialized phase data twice before patching the challenge, and both serializers kept scheduledStartDate but dropped scheduledEndDate. What was changed Preserved scheduledEndDate in the challenge editor phase mapper and the challenges service payload serializer so edited phase end dates reach the API on update and create flows. Added focused coverage for form-data transformation and the patch request payload. Any added/updated tests Added a challenge editor utility test covering scheduledEndDate serialization. Added a challenges service test covering scheduledEndDate in the patch payload.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Edit challenge saves reported success even when a phase end date had been changed, but the updated end date was missing after reload because the save request omitted it.
Root cause (if identifiable)
The challenge editor serialized phase data twice before patching the challenge, and both serializers kept scheduledStartDate but dropped scheduledEndDate.
What was changed
Preserved scheduledEndDate in the challenge editor phase mapper and the challenges service payload serializer so edited phase end dates reach the API on update and create flows.
Added focused coverage for form-data transformation and the patch request payload.
Any added/updated tests
Added a challenge editor utility test covering scheduledEndDate serialization.
Added a challenges service test covering scheduledEndDate in the patch payload.