Conversation
What was broken The challenge draft and read-only challenge editor still rendered an Attachments section even though that workflow is no longer relied on and is not behaving correctly. Root cause ChallengeEditorForm continued to mount the legacy attachments block in both editable and read-only layouts. What was changed Removed the Attachments section from ChallengeEditorForm so it no longer appears in the work app challenge editor. Updated the existing challenge editor spec to assert the section is absent in both read-only ordering coverage and editable draft rendering. Any added/updated tests Updated ChallengeEditorForm.spec.tsx to verify the attachments heading is not rendered in read-only mode and that the mock attachments control is absent while editing a draft.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The challenge draft and read-only challenge editor still rendered an Attachments section even though that workflow is no longer relied on and is not behaving correctly.
Root cause
ChallengeEditorForm continued to mount the legacy attachments block in both editable and read-only layouts.
What was changed
Removed the Attachments section from ChallengeEditorForm so it no longer appears in the work app challenge editor.
Updated the existing challenge editor spec to assert the section is absent in both read-only ordering coverage and editable draft rendering.
Any added/updated tests
Updated ChallengeEditorForm.spec.tsx to verify the attachments heading is not rendered in read-only mode and that the mock attachments control is absent while editing a draft.