Conversation
What was broken
Users could type a new group name into the Create Challenge groups field and select the generated "Create ..." option, which led to a failing group-create request and no useful UI response.
Root cause (if identifiable)
The challenge groups field reused a shared async-creatable select, so it exposed inline group creation even though the challenge flow already has a separate modal-based group creation path.
What was changed
Added an explicit `isCreatable` switch to the shared work-app groups select and disabled inline creation for the challenge editor groups field, leaving the existing modal-based create-group flow in place.
Any added/updated tests
Updated the challenge groups field test to assert that the challenge editor passes `isCreatable={false}` while preserving the existing modal create-group behavior.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Users could type a new group name into the Create Challenge groups field and select the generated "Create ..." option, which led to a failing group-create request and no useful UI response.
Root cause (if identifiable)
The challenge groups field reused a shared async-creatable select, so it exposed inline group creation even though the challenge flow already has a separate modal-based group creation path.
What was changed
Added an explicit
isCreatableswitch to the shared work-app groups select and disabled inline creation for the challenge editor groups field, leaving the existing modal-based create-group flow in place.Any added/updated tests
Updated the challenge groups field test to assert that the challenge editor passes
isCreatable={false}while preserving the existing modal create-group behavior.