PM-4813: show all assigned reviewers in view mode#1719
Merged
jmgasper merged 1 commit intotopcoder-platform:devfrom Apr 10, 2026
Merged
PM-4813: show all assigned reviewers in view mode#1719jmgasper merged 1 commit intotopcoder-platform:devfrom
jmgasper merged 1 commit intotopcoder-platform:devfrom
Conversation
What was broken In design challenges, the read-only review configuration summary could omit assigned reviewers when multiple reviewer rows resolved to the same resource role. The legacy work-manager summary showed those assignments, but the platform-ui view could leave later rows blank or repeated. Root cause (if identifiable) The summary resolved assigned members independently for each reviewer row by taking the first matching resources for that role every time. When repeated reviewer rows shared a role, later rows reused the same initial resources instead of consuming the remaining assignments in row order. What was changed The human-review summary now resolves the reviewer role id separately and builds assigned-member labels across all reviewer rows in order, tracking per-role offsets so repeated rows consume distinct persisted assignments. The human-review table row keys were also made explicitly unique, and the ChallengeEditorPage README was updated to document the repeated-role summary behavior. Any added/updated tests Added a regression test covering repeated approval rows that share the same resource role and asserting that each row shows a different assigned member in view mode.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
In design challenges, the read-only review configuration summary could omit assigned reviewers when multiple reviewer rows resolved to the same resource role. The legacy work-manager summary showed those assignments, but the platform-ui view could leave later rows blank or repeated.
Root cause (if identifiable)
The summary resolved assigned members independently for each reviewer row by taking the first matching resources for that role every time. When repeated reviewer rows shared a role, later rows reused the same initial resources instead of consuming the remaining assignments in row order.
What was changed
The human-review summary now resolves the reviewer role id separately and builds assigned-member labels across all reviewer rows in order, tracking per-role offsets so repeated rows consume distinct persisted assignments. The human-review table row keys were also made explicitly unique, and the ChallengeEditorPage README was updated to document the repeated-role summary behavior.
Any added/updated tests
Added a regression test covering repeated approval rows that share the same resource role and asserting that each row shows a different assigned member in view mode.