Conversation
PM-4305 Remove photo url check for completed profiles
PM- 4491 Include first name last name in challenge reports
What was broken Marathon Match challenge exports in the new challenge reports only exposed provisionalScore and finalRank. When a challenge only had final review scores for some members, those rows exported with blank score cells and no finalScore column even though the ranking logic already had access to final scores. Root cause (if identifiable) The earlier PM-4151 follow-up on develop reshaped Marathon Match rows to publish only provisionalScore and finalRank. The SQL still loaded final review scores for effective ranking, but the report queries and formatter never projected finalScore into the exported record shape. What was changed Added finalScore to the Marathon Match challenge report DTO and formatter output. Updated the submitters, valid-submitters, and winners SQL to emit rounded finalScore values while preserving the existing effective-rank ordering and tie-break behavior. Updated the challenge report catalog descriptions to document provisionalScore and finalScore availability. Included the repo lint auto-format on one existing conditional in topcoder-reports.service.ts. Any added/updated tests Added ChallengesReportsService regression tests covering Marathon Match submitter and winner exports plus the unchanged standard challenge submissionScore shape. The new challenge report spec passes. The repo-wide pnpm test command still fails in unrelated pre-existing SFDC specs on this branch.
What was broken Marathon Match challenge exports in the new challenge reports only exposed provisionalScore and finalRank. When a challenge only had final review scores for some members, those rows exported with blank score cells and no finalScore column even though the ranking logic already had access to final scores. Root cause (if identifiable) The earlier PM-4151 follow-up on develop reshaped Marathon Match rows to publish only provisionalScore and finalRank. The SQL still loaded final review scores for effective ranking, but the report queries and formatter never projected finalScore into the exported record shape. What was changed Added finalScore to the Marathon Match challenge report DTO and formatter output. Updated the submitters, valid-submitters, and winners SQL to emit rounded finalScore values while preserving the existing effective-rank ordering and tie-break behavior. Updated the challenge report catalog descriptions to document provisionalScore and finalScore availability. Aligned the new challenge report regression spec with the current develop branch export shape, including firstName and lastName fields. Included the repo lint auto-format on one existing conditional in topcoder-reports.service.ts. Any added/updated tests Added ChallengesReportsService regression tests covering Marathon Match submitter and winner exports plus the unchanged standard challenge submissionScore shape on the current export record format. Verified pnpm lint, the new challenge report spec, and pnpm build on this branch. The repo-wide pnpm test command still fails in unrelated pre-existing SFDC specs on the current develop base.
PM-4151: add MM final scores to challenge exports
What was broken The PM-4151 challenge export regression spec on current develop still asserted the older export shape without firstName and lastName, so the focused challenge report test failed even though the Marathon Match finalScore export fix had already been merged. Root cause (if identifiable) The earlier follow-up branch updated the regression spec for the current export shape, but that spec change never landed on top of the develop branch after firstName and lastName were added to challenge user exports. What was changed Updated the challenge report regression fixtures and expectations to include firstName and lastName for Marathon Match and standard challenge exports. Kept the follow-up scoped to the regression coverage only because the functional MM finalScore export fix is already present on develop. Any added/updated tests Updated src/reports/challenges/challenges-reports.service.spec.ts to assert the current export columns. Verified pnpm lint, pnpm test --runInBand src/reports/challenges/challenges-reports.service.spec.ts, and pnpm build on this branch. The full pnpm test --runInBand suite still fails in unrelated pre-existing SFDC specs on the current develop base.
PM-4151: align challenge export regression spec with names
What was broken Marathon Match submitter, valid submitter, and winner exports could leave finalScore blank when a final score existed only on the reviews.submission record. QA still reported blank score columns in production for those cases. Root cause The challenge export SQL only projected final_score_raw from the latest non-provisional reviewSummation row even though the surrounding scoring logic already treats submission.finalScore as a valid fallback source. What was changed Updated the three Marathon Match challenge export queries to use COALESCE(final_review.aggregateScore, submission.finalScore) for final_score_raw so the export keeps finalScore populated when review summary rows are absent. Any added/updated tests Added a regression spec that loads the submitters, valid-submitters, and winners SQL files and asserts they all preserve the submission.finalScore fallback.
PM-4151: add MM final scores to challenge exports
PM-4151: fallback MM export final scores to submission data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-4305
https://topcoder.atlassian.net/browse/PM-4491
https://topcoder.atlassian.net/browse/PM-4800