Permissions hotfix #1743
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| /* global describe, it, expect, beforeEach, afterEach, jest */ | ||
|
|
||
| import React from 'react' | ||
| import ReactDOM from 'react-dom' | ||
| import { act } from 'react-dom/test-utils' | ||
| import UpdateBillingAccount from './index' | ||
|
|
||
| jest.mock('../Select', () => () => null) | ||
| jest.mock('../Buttons', () => { | ||
| const React = require('react') | ||
|
|
||
| const renderButton = (text) => React.createElement( | ||
| 'button', | ||
| { type: 'button' }, | ||
| text | ||
| ) | ||
|
|
||
| return { | ||
| PrimaryButton: ({ text }) => renderButton(text), | ||
| OutlineButton: ({ text }) => renderButton(text) | ||
| } | ||
| }) | ||
|
|
||
| describe('UpdateBillingAccount', () => { | ||
| let container | ||
|
|
||
| const defaultProps = { | ||
| billingAccounts: [], | ||
| isBillingAccountsLoading: false, | ||
| isBillingAccountLoading: false, | ||
| isBillingAccountLoadingFailed: false, | ||
| billingStartDate: 'Jan 01, 2026', | ||
| billingEndDate: 'Dec 31, 2026', | ||
| isBillingAccountExpired: false, | ||
| canManageBillingAccount: false, | ||
| currentBillingAccount: null, | ||
| projectId: 1001, | ||
| updateProject: () => {} | ||
| } | ||
|
|
||
| const renderComponent = (props = {}) => { | ||
| act(() => { | ||
| ReactDOM.render( | ||
| <UpdateBillingAccount {...defaultProps} {...props} />, | ||
| container | ||
| ) | ||
| }) | ||
| } | ||
|
|
||
| beforeEach(() => { | ||
| container = document.createElement('div') | ||
| document.body.appendChild(container) | ||
| }) | ||
|
|
||
| afterEach(() => { | ||
| ReactDOM.unmountComponentAtNode(container) | ||
| container.remove() | ||
| container = null | ||
| }) | ||
|
|
||
| it('shows the select action when the user can manage billing accounts and none is assigned', () => { | ||
| renderComponent({ | ||
| canManageBillingAccount: true, | ||
| isBillingAccountLoadingFailed: true | ||
| }) | ||
|
|
||
| expect(container.textContent).toContain('No Billing Account set') | ||
| expect(container.textContent).toContain('Select Billing Account') | ||
| }) | ||
|
|
||
| it('shows the edit action when the user can manage an assigned billing account', () => { | ||
| renderComponent({ | ||
| canManageBillingAccount: true, | ||
| currentBillingAccount: 12345 | ||
| }) | ||
|
|
||
| expect(container.textContent).toContain('Billing Account:') | ||
| expect(container.textContent).toContain('Edit Billing Account') | ||
| }) | ||
|
|
||
| it('hides management actions when the user cannot manage billing accounts', () => { | ||
| renderComponent({ | ||
| currentBillingAccount: 12345 | ||
| }) | ||
|
|
||
| expect(container.textContent).toContain('Billing Account:') | ||
| expect(container.textContent).not.toContain('Edit Billing Account') | ||
| expect(container.textContent).not.toContain('Select Billing Account') | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /** | ||
| * Returns project details only when they match the current project context. | ||
| * | ||
| * This prevents stale project data from rendering on another project page while | ||
| * still handling APIs that may return ids as strings. | ||
| * | ||
| * @param {Object} projectDetail Loaded project details from redux. | ||
| * @param {string|number} projectId Project id from the current route. | ||
| * @param {number} activeProjectId Active project id stored in the sidebar state. | ||
| * @returns {Object} The matching project detail object, or an empty object. | ||
| */ | ||
| export function getActiveProject (projectDetail, projectId, activeProjectId) { | ||
| if (!projectDetail) { | ||
| return {} | ||
| } | ||
|
|
||
| const scopedProjectId = projectId != null | ||
| ? `${projectId}` | ||
| : (activeProjectId != null && activeProjectId !== -1 ? `${activeProjectId}` : '') | ||
|
|
||
| if (!scopedProjectId || `${projectDetail.id}` !== scopedProjectId) { | ||
| return {} | ||
| } | ||
|
|
||
| return projectDetail | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* global describe, it, expect */ | ||
|
|
||
| import { getActiveProject } from './helper' | ||
|
|
||
| describe('getActiveProject', () => { | ||
| it('returns the project detail when the route project id matches a string project id', () => { | ||
| const projectDetail = { | ||
| id: '100566', | ||
| name: 'Project Phoenix' | ||
| } | ||
|
|
||
| expect(getActiveProject(projectDetail, 100566, 100566)).toEqual(projectDetail) | ||
| }) | ||
|
|
||
| it('returns an empty object when the loaded project does not match the current project context', () => { | ||
| const projectDetail = { | ||
| id: '100566', | ||
| name: 'Project Phoenix' | ||
| } | ||
|
|
||
| expect(getActiveProject(projectDetail, 100567, 100567)).toEqual({}) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[⚠️
maintainability]The
PROJECT_API_URLis set to use the development API host (DEV_API_HOSTNAME). Consider using the local endpointLOCAL_PROJECTS_APIfor consistency with other local services, unless there's a specific reason to keep it on the dev environment.