Conversation
What was broken The design challenge editor still showed an Unlimited submissions option even though that control is no longer used and did not work as expected. Root cause The maximum submissions field still rendered the legacy Unlimited checkbox and the editor still carried an update path for that unused metadata toggle. What was changed Removed the editable Unlimited checkbox from the design challenge maximum submissions field. Removed the unused unlimited update branch from challenge metadata handling. Kept the existing read-only display for legacy unlimited metadata so older challenge data still renders consistently. Any added/updated tests Added a MaximumSubmissionsField component test that covers removing the editable Unlimited option, preserving the legacy read-only display, and sanitizing the count input.
What was broken The previous fix only removed the editable Unlimited toggle. Design challenges still showed the submission limit section, accepted a limit value that was not enforced, and continued to show a submission limit summary in read-only views. Root cause TextEditorField still rendered MaximumSubmissionsField for design challenges in both edit and read-only flows, and ChallengeEditor still carried dead submissionLimit metadata update logic for that removed behavior. What was changed Removed the submission limit section from design challenge text rendering. Deleted the unused MaximumSubmissionsField component and styles. Removed the obsolete submissionLimit metadata handling path from ChallengeEditor. Any added/updated tests Added TextEditorField tests that verify the submission limit section is hidden in both edit and read-only design challenge views. Removed the obsolete MaximumSubmissionsField component tests with the deleted component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The previous fix only removed the editable Unlimited toggle. Design challenges still showed the submission limit section, accepted a limit value that was not enforced, and continued to show a submission limit summary in read-only views.
Root cause
TextEditorField still rendered MaximumSubmissionsField for design challenges in both edit and read-only flows, and ChallengeEditor still carried dead submissionLimit metadata update logic for that removed behavior.
What was changed
Removed the submission limit section from design challenge text rendering.
Deleted the unused MaximumSubmissionsField component and styles.
Removed the obsolete submissionLimit metadata handling path from ChallengeEditor.
Any added/updated tests
Added TextEditorField tests that verify the submission limit section is hidden in both edit and read-only design challenge views.
Removed the obsolete MaximumSubmissionsField component tests with the deleted component.