fix: ensure AddIndex, AddConstraint, RemoveIndex and RemoveConstraint are in correct order#2118
Open
tsifrer wants to merge 3 commits intotortoise:developfrom
Open
fix: ensure AddIndex, AddConstraint, RemoveIndex and RemoveConstraint are in correct order#2118tsifrer wants to merge 3 commits intotortoise:developfrom
tsifrer wants to merge 3 commits intotortoise:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensures migration generator now correctly orders
AddIndex,AddConstraint,RemoveIndex,RemoveConstraintwhen adding/removing a new indexed field or constraint field to a model.Motivation and Context
When adding a new field on an existing model, and using that field in as an index or a constraint, the migration creates operations in the wrong order.
Going from this model:
to this model:
would generate a migration file with operations in order:
[AddIndex, AddField]causing migration to fail as it can't add an index to a non existing field.This PR fixes this order.
Checklist: