Explicit precedence clarifies logic in UseOfLegacyAlgorithm.ql#36
Merged
GrosQuildu merged 1 commit intomainfrom Feb 25, 2026
Merged
Explicit precedence clarifies logic in UseOfLegacyAlgorithm.ql#36GrosQuildu merged 1 commit intomainfrom
GrosQuildu merged 1 commit intomainfrom
Conversation
Not strictly a bugfix since CodeQL's precedence handles this already (disjunction occurs before conjunction) but the and/or logic for handling "DES" becomes clearer when wrapped in parens.
gsutherland-trailofbits
requested review from
GrosQuildu and
fegge
as code owners
Contributor
|
Oh man, I liked that addition but we are running autoformatting for codeql files and that removes the parentheses (in the other PR). Sorry, in the future we can try to configure the autoformatting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic in UseOfLegacyAlgorithm.ql current has bare and/or for the DES special-case, which is ambiguous if you don't know what CodeQL's conjunction/disjunction operator precedence is. The code is correct, but this PR adds parens to make it explicit and avoid confusion.