Open
Conversation
tomprats
reviewed
Mar 28, 2026
| const http = get(httpState); | ||
| const {applyAssessmentExpiration} = get(optionsState); | ||
| const variables = { | ||
| ...(applyAssessmentExpiration != null && {applyAssessmentExpiration}), |
Member
There was a problem hiding this comment.
This looks a little gross. Can we just add it in an if statement after variables is set?
| if(options.perspective) { return; } | ||
|
|
||
| setOptions({...options, perspective: "thirdPerson"}); | ||
| setOptions({...options, perspective: "thirdPerson", applyAssessmentExpiration: false}); |
Member
There was a problem hiding this comment.
This won't be set if perspective is already set. I think we might want to move it own useEffect or maybe just update this one to do something like:
const newOptions = {}
if(!Object.hasOwn(options, "applyAssessmentExpiration")) { newOptions.applyAssessmentExpiration = false; }
if(!Object.hasOwn(options, "perspective")) { newOptions.perspective = "thirdPerson"; }
if(Object.keys(newOptions).length > 0) { setOptions(newOptions); }
That way it only sets them if they haven't already been set (like how perspective was before)
| { | ||
| "name": "traitify-widgets", | ||
| "version": "3.9.3", | ||
| "version": "3.9.4", |
Member
There was a problem hiding this comment.
Probably best not to publish a non-alpha until it gets merged into master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.