Forbid square brackets in reference link IDs (#680)#681
Merged
nicholasserra merged 1 commit intotrentm:masterfrom Mar 2, 2026
Merged
Forbid square brackets in reference link IDs (#680)#681nicholasserra merged 1 commit intotrentm:masterfrom
nicholasserra merged 1 commit intotrentm:masterfrom
Conversation
Collaborator
|
LGTM thanks! Gonna do a release after this. I'll update the changelog with this |
Contributor
Author
|
Ah sorry, was just trying to update the changelog from my end. My NAS rebooted in the middle of |
Collaborator
|
No worries it was perfect timing, I was about to do a release when this PR popped up :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #680 by forbidding square brackets in reference link IDs.
GFM spec describes the link labels as at least one whitespace character, not including unescaped square brackets. To make implementation easier, I've just forbidden square brackets outright. Our link definitions parsing doesn't support them anyway