Skip to content

Add support for pr:declined webhook event#58

Merged
trick77 merged 1 commit into
masterfrom
t3code/a955dbdf
May 18, 2026
Merged

Add support for pr:declined webhook event#58
trick77 merged 1 commit into
masterfrom
t3code/a955dbdf

Conversation

@trick77
Copy link
Copy Markdown
Owner

@trick77 trick77 commented May 18, 2026

Summary

  • Add pr:declined to the required webhook events in the Bitbucket onboarding script
  • Create a fixture (bitbucket_pr_declined.json) with a realistic declined PR payload
  • Add parser tests that verify the declined event produces a BitbucketEventDraft with correctly lowered join keys (repo_full_name, branch_name, commit_sha), parsed change type, and extracted Jira keys

Testing

  • uv run pytest tests/test_parsers_bitbucket.py::TestExtractPrDeclined — passes
  • uv run pytest tests/ — Not run
  • uv run ruff check . && uv run ruff format --check . — Not run
  • uv run pyright — Not run

@trick77 trick77 merged commit 0fcb68d into master May 18, 2026
2 checks passed
@trick77 trick77 deleted the t3code/a955dbdf branch May 18, 2026 18:56
trick77 added a commit that referenced this pull request May 18, 2026
Resolve conflict in tests/test_parsers_bitbucket.py by keeping both new
test classes — TestExtractPrDeclined from #58 (master) and
TestExtractPrModified from this branch. The pr:declined and
pr:modified work is orthogonal; both belong in the parser tests.

The script's REQUIRED_WEBHOOK_EVENTS tuple auto-merged with pr:declined
inserted next to pr:modified — no manual fix-up needed there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant