-
-
Notifications
You must be signed in to change notification settings - Fork 972
chore(deps): bump @remix-run/node from 2.1.0 to 2.17.2 #2854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/npm_and_yarn/remix-run/node-2.17.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Remix package version mismatch causes duplicate server-runtime installations
Bumping only
@remix-run/nodefrom 2.1.0 to 2.17.2 while keeping all other@remix-run/*packages at 2.1.0 creates a version mismatch that violates Remix's compatibility requirements.Click to expand
The Problem
@remix-run/node@2.17.2brings its own@remix-run/server-runtime@2.17.2as a transitive dependency, while the webapp and other Remix packages depend on@remix-run/server-runtime@2.1.0.From the lockfile:
This means both versions are installed:
Impact
The codebase extensively imports from both
@remix-run/nodeand@remix-run/server-runtimedirectly. For example:apps/webapp/app/entry.server.tsx:1imports from@remix-run/node(uses 2.17.2's server-runtime)json,redirect,LoaderFunctionArgsfrom@remix-run/server-runtimedirectly (uses 2.1.0)@remix-run/express@2.1.0and@remix-run/react@2.1.0use 2.1.0's server-runtimeThis version mismatch could cause:
json()orredirect()Recommendation
All
@remix-run/*packages should be updated together to 2.17.2 to maintain compatibility.Recommendation: Update all @remix-run/* packages to 2.17.2 together: @remix-run/express, @remix-run/react, @remix-run/serve, @remix-run/server-runtime, @remix-run/dev, @remix-run/eslint-config, and @remix-run/testing should all be bumped to maintain version consistency.
Was this helpful? React with 👍 or 👎 to provide feedback.