fix: add build step to @internal/compute package by nicktrn · Pull Request #3303 · triggerdotdev/trigger.dev

nicktrn · 2026-03-31T12:12:23Z

The @internal/compute package had its main/types pointing to ./src/index.ts with no build step. This works in dev (tsc resolves .ts at compile time) but fails at runtime in Docker because Node.js can't load .ts files directly.

Added tsconfig.build.json and build/clean/dev scripts matching the pattern used by schedule-engine and other internal packages. Exports now point to dist/.

changeset-bot · 2026-03-31T12:12:30Z

⚠️ No Changeset found

Latest commit: 726ad0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-31T12:12:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 23189fe3-a57b-4bda-9be9-dbe2c4977e5d

📥 Commits

Reviewing files that changed from the base of the PR and between 1307d97 and 726ad0e.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

internal-packages/compute/package.json
internal-packages/compute/tsconfig.build.json

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)

GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
GitHub Check: typecheck / typecheck
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
GitHub Check: sdk-compat / Node.js 22.12 (ubuntu-latest)
GitHub Check: sdk-compat / Node.js 20.20 (ubuntu-latest)
GitHub Check: sdk-compat / Cloudflare Workers
GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
GitHub Check: sdk-compat / Bun Runtime
GitHub Check: sdk-compat / Deno Runtime
GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{js,ts,jsx,tsx,json,md,yaml,yml}

📄 CodeRabbit inference engine (AGENTS.md)

Format code using Prettier before committing

Files:

internal-packages/compute/tsconfig.build.json
internal-packages/compute/package.json

🧠 Learnings (18)

📓 Common learnings

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/cli-v3/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:34.140Z
Learning: Applies to packages/cli-v3/src/build/**/* : Bundle worker code using the build system in `src/build/` based on configuration from `trigger.config.ts`

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/cli-v3/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:34.140Z
Learning: Applies to packages/cli-v3/src/build/**/* : Build system in `src/build/` should use configuration from `trigger.config.ts` in user projects to determine bundling, build extensions, and output structure

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-29T21:04:38.161Z
Learning: Applies to packages/**/*.ts : Use `build` to verify changes in public packages (`packages/*`, `integrations/*`), not `typecheck`

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-29T21:04:38.161Z
Learning: Applies to **/*.ts : Use `typecheck` to verify changes in apps and internal packages (`apps/*`, `internal-packages/*`), not `build` - building proves almost nothing about correctness

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-29T21:04:38.161Z
Learning: Applies to packages/**/*.{ts,tsx,json} : Add a changeset when modifying any public package (`packages/*` or `integrations/*`) using `pnpm run changeset:add`, defaulting to patch for bug fixes, requiring maintainer confirmation for minor/major changes

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 2710
File: packages/schema-to-json/package.json:0-0
Timestamp: 2025-11-26T14:40:07.146Z
Learning: Node.js 24+ has native TypeScript support and can execute .ts files directly without tsx or ts-node for scripts that use only erasable TypeScript syntax (type annotations, interfaces, etc.). The trigger.dev repository uses Node.js 24.11.1+ and scripts like updateVersion.ts can be run with `node` instead of `tsx`.

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to trigger.config.ts : Configure build options including `external` packages, `jsx` settings, `conditions`, and `extensions` in the `build` option

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T16:26:37.432Z
Learning: Applies to packages/trigger-sdk/**/*.{ts,tsx} : In the Trigger.dev SDK (packages/trigger-sdk), prefer isomorphic code like fetch and ReadableStream instead of Node.js-specific code

📚 Learning: 2026-03-02T12:43:34.140Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/cli-v3/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:34.140Z
Learning: Applies to packages/cli-v3/src/build/**/* : Build system in `src/build/` should use configuration from `trigger.config.ts` in user projects to determine bundling, build extensions, and output structure

Applied to files:

internal-packages/compute/tsconfig.build.json
internal-packages/compute/package.json

📚 Learning: 2026-03-29T21:04:38.161Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-29T21:04:38.161Z
Learning: Applies to packages/**/*.ts : Use `build` to verify changes in public packages (`packages/*`, `integrations/*`), not `typecheck`

Applied to files:

internal-packages/compute/tsconfig.build.json
internal-packages/compute/package.json

📚 Learning: 2026-03-29T21:04:38.161Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-29T21:04:38.161Z
Learning: Applies to **/*.ts : Use `typecheck` to verify changes in apps and internal packages (`apps/*`, `internal-packages/*`), not `build` - building proves almost nothing about correctness

Applied to files:

internal-packages/compute/tsconfig.build.json
internal-packages/compute/package.json

📚 Learning: 2025-11-27T16:26:37.432Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T16:26:37.432Z
Learning: Applies to **/tsconfig.json : Use strict mode in TypeScript configuration

Applied to files:

internal-packages/compute/tsconfig.build.json

📚 Learning: 2026-03-25T15:29:25.853Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to trigger.config.ts : Configure build options including `external` packages, `jsx` settings, `conditions`, and `extensions` in the `build` option

Applied to files:

internal-packages/compute/tsconfig.build.json
internal-packages/compute/package.json

📚 Learning: 2026-03-02T12:43:34.140Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/cli-v3/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:34.140Z
Learning: Applies to packages/cli-v3/src/build/**/* : Bundle worker code using the build system in `src/build/` based on configuration from `trigger.config.ts`

Applied to files:

internal-packages/compute/tsconfig.build.json
internal-packages/compute/package.json

📚 Learning: 2026-03-29T21:04:38.161Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-29T21:04:38.161Z
Learning: Applies to packages/**/*.{ts,tsx,json} : Add a changeset when modifying any public package (`packages/*` or `integrations/*`) using `pnpm run changeset:add`, defaulting to patch for bug fixes, requiring maintainer confirmation for minor/major changes

Applied to files:

internal-packages/compute/tsconfig.build.json
internal-packages/compute/package.json

📚 Learning: 2025-11-26T14:40:07.146Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 2710
File: packages/schema-to-json/package.json:0-0
Timestamp: 2025-11-26T14:40:07.146Z
Learning: Node.js 24+ has native TypeScript support and can execute .ts files directly without tsx or ts-node for scripts that use only erasable TypeScript syntax (type annotations, interfaces, etc.). The trigger.dev repository uses Node.js 24.11.1+ and scripts like updateVersion.ts can be run with `node` instead of `tsx`.

Applied to files:

internal-packages/compute/tsconfig.build.json
internal-packages/compute/package.json

📚 Learning: 2025-11-27T16:26:58.661Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-11-27T16:26:58.661Z
Learning: Applies to apps/webapp/**/*.{ts,tsx} : When importing from `trigger.dev/core` in the webapp, use subpath exports from the package.json instead of importing from the root path

Applied to files:

internal-packages/compute/package.json

📚 Learning: 2026-03-02T12:43:48.124Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/trigger-sdk/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:48.124Z
Learning: Applies to packages/trigger-sdk/**/*.{ts,tsx,js,jsx} : Always import from `trigger.dev/sdk`. Never use `trigger.dev/sdk/v3` (deprecated path alias)

Applied to files:

internal-packages/compute/package.json

📚 Learning: 2025-11-27T16:26:58.661Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-11-27T16:26:58.661Z
Learning: Applies to apps/webapp/**/*.{ts,tsx} : Follow the Remix 2.1.0 and Express server conventions when updating the main trigger.dev webapp

Applied to files:

internal-packages/compute/package.json

📚 Learning: 2026-03-29T21:04:38.161Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-29T21:04:38.161Z
Learning: Applies to packages/core/**/*.ts : Import subpaths only from `trigger.dev/core`, never import from the root

Applied to files:

internal-packages/compute/package.json

📚 Learning: 2026-03-29T21:04:38.161Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-29T21:04:38.161Z
Learning: This is a pnpm 10.23.0 monorepo using Turborepo - run commands from root with `pnpm run`

Applied to files:

internal-packages/compute/package.json

📚 Learning: 2025-11-27T16:26:37.432Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T16:26:37.432Z
Learning: The SDK at packages/trigger-sdk is an isomorphic TypeScript SDK

Applied to files:

internal-packages/compute/package.json

📚 Learning: 2026-03-25T15:29:25.853Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Import from `trigger.dev/sdk` (NEVER from `trigger.dev/sdk/v3`)

Applied to files:

internal-packages/compute/package.json

📚 Learning: 2026-03-25T15:29:25.853Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to trigger.config.ts : Configure the Trigger.dev project using `defineConfig()` with properties like `project`, `dirs`, `retries`, `runtime`, and `build`

Applied to files:

internal-packages/compute/package.json

📚 Learning: 2025-11-27T16:26:44.496Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/executing-commands.mdc:0-0
Timestamp: 2025-11-27T16:26:44.496Z
Learning: For running tests, navigate into the package directory and run `pnpm run test --run` to enable single-file test execution (e.g., `pnpm run test ./src/engine/tests/ttl.test.ts --run`)

Applied to files:

internal-packages/compute/package.json

🔇 Additional comments (4)

internal-packages/compute/tsconfig.build.json (2)

2-3: Build input scoping looks good.

Including src/**/*.ts while excluding src/**/*.test.ts keeps emitted artifacts focused on runtime code.

5-20: Compiler options are coherent for a distributable internal package.

composite + outDir + declaration + strict is a solid setup for generating typed runtime artifacts in dist/.

internal-packages/compute/package.json (2)

5-15: Entrypoint and exports migration is correct.

Switching main/types to dist and adding conditional exports cleanly separates runtime resolution from source-resolution workflows.

19-27: Build scripts/tooling addition is well-structured.

clean, build, and dev scripts are consistent with the new tsconfig.build.json flow and address the missing runtime build step.

Walkthrough

This pull request updates the build infrastructure for the internal-packages/compute package. The package.json file was modified to redirect module entry points from source TypeScript files to compiled JavaScript artifacts in a dist directory, adds an export map for conditional resolution, and introduces build scripts (clean, build, dev) along with rimraf as a dev dependency. A new TypeScript build configuration file (tsconfig.build.json) was created to define compilation settings targeting ES2020 with Node16-compatible module resolution, strict type-checking, and declaration file generation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description provides context about the problem (missing build step causing runtime failures in Docker) and explains the solution, but does not follow the repository's required template structure.	Add a proper description following the template with Closes #, Testing section, Changelog, Screenshots (if applicable), and Checklist items marked as completed.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a build step to the `@internal/compute` package.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/compute-package-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

nicktrn · 2026-03-31T12:21:19Z

ready

fix: add build step to @internal/compute package

726ad0e

devin-ai-integration bot reviewed Mar 31, 2026

View reviewed changes

nicktrn added the ready label Mar 31, 2026

ericallam approved these changes Mar 31, 2026

View reviewed changes

myftija approved these changes Mar 31, 2026

View reviewed changes

nicktrn merged commit 2ba77d8 into main Mar 31, 2026
42 checks passed

nicktrn deleted the fix/compute-package-build branch March 31, 2026 12:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add build step to @internal/compute package#3303

fix: add build step to @internal/compute package#3303
nicktrn merged 1 commit intomainfrom
fix/compute-package-build

nicktrn commented Mar 31, 2026

Uh oh!

changeset-bot bot commented Mar 31, 2026

Uh oh!

coderabbitai bot commented Mar 31, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

nicktrn commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nicktrn commented Mar 31, 2026

Uh oh!

changeset-bot bot commented Mar 31, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

nicktrn commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Mar 31, 2026 •

edited

Loading