Skip to content

Conversation

@benegee
Copy link
Collaborator

@benegee benegee commented Oct 8, 2025

No description provided.

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.11%. Comparing base (8598d3c) to head (2ea92cc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          25       25           
  Lines        1260     1260           
  Branches       74       74           
=======================================
  Hits         1211     1211           
  Misses         45       45           
  Partials        4        4           
Flag Coverage Δ
unittests 96.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benegee
Copy link
Collaborator Author

benegee commented Oct 9, 2025

Issues so far:

  1. unused parameter in julia.h (warning being treated as error)

    In file included from /opt/hostedtoolcache/julia/1.12.0/x64/include/julia/julia.h:73,
                   from /home/runner/work/libtrixi/libtrixi/src/auxiliary.h:4,
                   from /home/runner/work/libtrixi/libtrixi/src/api.c:2:
    /opt/hostedtoolcache/julia/1.12.0/x64/include/julia/gc-interface.h: In function ‘jl_gc_wb_fresh’:
    /opt/hostedtoolcache/julia/1.12.0/x64/include/julia/gc-interface.h:243:47: error: unused parameter ‘parent’ [-Werror=unused-parameter]
    
  2. some curl related error

    ┌ Error: curl_multi_assign: 1
    └ @ Downloads.Curl /opt/hostedtoolcache/julia/1.12.0/x64/share/julia/stdlib/v1.12/Downloads/src/Curl/utils.jl:57
    
    [9665] signal 6 (-6): Aborted
    

    (was caused by LD_PRELOADed libcurl)

  3. when running trixi_controller_simple_c

    WARNING: Detected access to binding `Main.init_simstate` in a world prior to its definition world.
      Julia 1.12 has introduced more strict world age semantics for global bindings.
      !!! This code may malfunction under Revise.
      !!! This code will error in future versions of Julia.
    Hint: Add an appropriate `invokelatest` around the access to this binding.
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants