Temporal/after rebase

Cargo.toml

@@ -52,6 +52,7 @@ unicode-normalization = "0.1.24"
 usdt = { git = "https://github.com/aapoalas/usdt.git", branch = "nova-aarch64-branch" }
 wtf8 = "0.1"
 xsum = "0.1.6"
+temporal_rs = "0.1.0"
 
 [workspace.metadata.dylint]
 libraries = [{ path = "nova_lint" }]

nova_vm/Cargo.toml

@@ -40,6 +40,7 @@ unicode-normalization = { workspace = true }
 usdt = { workspace = true }
 wtf8 = { workspace = true }
 xsum = { workspace = true }
+temporal_rs = { workspace = true, optional = true }
 
 [features]
 default = [
@@ -53,9 +54,15 @@ default = [
     "regexp",
     "set",
     "annex-b",
+    "temporal",
 ]
 array-buffer = ["ecmascript_atomics"]
-atomics = ["array-buffer", "shared-array-buffer", "ecmascript_atomics", "ecmascript_futex"]
+atomics = [
+    "array-buffer",
+    "shared-array-buffer",
+    "ecmascript_atomics",
+    "ecmascript_futex",
+]
 date = []
 json = ["dep:sonic-rs"]
 math = []
@@ -64,6 +71,7 @@ shared-array-buffer = ["array-buffer", "ecmascript_atomics"]
 weak-refs = []
 set = []
 typescript = []
+temporal = ["temporal_rs"]
 
 # Enables features defined by [Annex B](https://tc39.es/ecma262/#sec-additional-ecmascript-features-for-web-browsers)
 annex-b = ["annex-b-string", "annex-b-global", "annex-b-date", "annex-b-regexp"]
@@ -84,6 +92,7 @@ proposals = [
     "proposal-math-clamp",
     "proposal-is-error",
     "proposal-atomics-microwait",
+    "proposal-temporal",
 ]
 # Enables the [Float16Array proposal](https://tc39.es/proposal-float16array/)
 proposal-float16array = ["array-buffer"]
@@ -93,6 +102,8 @@ proposal-math-clamp = ["math"]
 proposal-is-error = []
 # Enables the [Atomics.pause proposal](https://tc39.es/proposal-atomics-microwait/)
 proposal-atomics-microwait = ["atomics"]
+# Enable the [Temporal proposal](https://tc39.es/proposal-temporal/)
+proposal-temporal = ["temporal"]
 
 [build-dependencies]
 small_string = { path = "../small_string", version = "0.2.0" }

nova_vm/src/builtin_strings

@@ -28,7 +28,7 @@ __proto__
 #[cfg(feature = "math")]abs
 #[cfg(feature = "math")]acos
 #[cfg(feature = "math")]acosh
-#[cfg(any(feature = "atomics", feature = "set", feature = "weak-refs"))]add
+#[cfg(any(feature = "atomics", feature = "set", feature = "weak-refs", feature = "temporal"))]add
 AggregateError
 all
 allSettled
@@ -87,13 +87,15 @@ codePointAt
 concat
 configurable
 construct
+compare
 constructor
 copyWithin
 #[cfg(feature = "math")]cos
 #[cfg(feature = "math")]cosh
 create
 #[cfg(feature = "array-buffer")]DataView
 #[cfg(feature = "date")]Date
+#[cfg(feature = "temporal")]days
 decodeURI
 decodeURIComponent
 default
@@ -106,13 +108,17 @@ description
 #[cfg(feature = "array-buffer")]detached
 done
 #[cfg(feature = "regexp")]dotAll
+#[cfg(feature="temporal")]Duration
 #[cfg(feature = "math")]E
 encodeURI
 encodeURIComponent
 endsWith
 entries
 enumerable
+#[cfg(feature = "temporal")]epochMilliseconds
+#[cfg(feature = "temporal")]epochNanoseconds
 EPSILON
+#[cfg(feature = "temporal")]equals
 Error
 errors
 #[cfg(any(feature = "annex-b-string", feature = "regexp"))]escape
@@ -133,6 +139,7 @@ find
 findIndex
 findLast
 findLastIndex
+#[cfg(feature = "temporal")]fractionalSecondDigits
 #[cfg(feature = "annex-b-string")]fixed
 #[cfg(feature = "regexp")]flags
 flat
@@ -147,6 +154,8 @@ for
 forEach
 freeze
 from
+#[cfg(feature = "temporal")]fromEpochNanoseconds
+#[cfg(feature = "temporal")]fromEpochMilliseconds
 fromCharCode
 fromCodePoint
 fromEntries
@@ -183,6 +192,8 @@ get size
 #[cfg(feature = "array-buffer")]getBigUint64
 #[cfg(feature = "date")]getDate
 #[cfg(feature = "date")]getDay
+#[cfg(feature = "temporal")]get epochMilliseconds
+#[cfg(feature = "temporal")]get epochNanoseconds
 #[cfg(feature = "proposal-float16array")]getFloat16
 #[cfg(feature = "array-buffer")]getFloat32
 #[cfg(feature = "array-buffer")]getFloat64
@@ -225,6 +236,7 @@ hasInstance
 hasOwn
 hasOwnProperty
 #[cfg(feature = "math")]hypot
+#[cfg(feature = "temporal")]hours
 #[cfg(feature = "regexp")]ignoreCase
 #[cfg(feature = "math")]imul
 includes
@@ -250,6 +262,8 @@ isSealed
 #[cfg(feature = "array-buffer")]isView
 isWellFormed
 #[cfg(feature = "annex-b-string")]italics
+#[cfg(feature = "temporal")]Instant
+#[cfg(feature = "temporal")]largestUnit
 Iterator
 iterator
 join
@@ -281,13 +295,18 @@ MAX_SAFE_INTEGER
 MAX_VALUE
 #[cfg(feature = "array-buffer")]maxByteLength
 message
+#[cfg(feature = "temporal")]microseconds
+#[cfg(feature = "temporal")]milliseconds
+#[cfg(feature = "temporal")]minutes
+#[cfg(feature = "temporal")]months
 #[cfg(feature = "math")]min
 MIN_SAFE_INTEGER
 MIN_VALUE
 Module
 #[cfg(feature = "regexp")]multiline
 name
 NaN
+#[cfg(feature = "temporal")]nanoseconds
 NEGATIVE_INFINITY
 next
 normalize
@@ -343,9 +362,12 @@ resolve
 return
 reverse
 revocable
-#[cfg(feature = "math")]round
+#[cfg(any(feature = "math", feature = "temporal"))]round
+#[cfg(feature = "temporal")]roundingMode
+#[cfg(feature = "temporal")]roundingIncrement
 seal
 #[cfg(feature = "regexp")]search
+#[cfg(feature = "temporal")]seconds
 set
 #[cfg(feature = "set")]Set
 set [Symbol.toStringTag]
@@ -381,10 +403,12 @@ setPrototypeOf
 shift
 #[cfg(feature = "math")]sign
 #[cfg(feature = "math")]sin
+#[cfg(feature = "temporal")]since
 #[cfg(feature = "math")]sinh
 size
 slice
 #[cfg(feature = "annex-b-string")]small
+#[cfg(feature = "temporal")]smallestUnit
 some
 sort
 #[cfg(feature = "regexp")]source
@@ -407,6 +431,7 @@ String Iterator
 #[cfg(feature = "array-buffer")]subarray
 #[cfg(feature = "annex-b-string")]substr
 substring
+#[cfg(feature = "temporal")]subtract
 sumPrecise
 #[cfg(feature = "annex-b-string")]sup
 symbol
@@ -426,12 +451,16 @@ Symbol.toPrimitive
 Symbol.toStringTag
 Symbol.unscopables
 SyntaxError
+#[cfg(feature = "temporal")]Temporal
+#[cfg(feature = "temporal")]Temporal.Duration
+#[cfg(feature = "temporal")]Temporal.Instant
 #[cfg(feature = "math")]tan
 #[cfg(feature = "math")]tanh
 #[cfg(feature = "regexp")]test
 then
 throw
 #[cfg(feature = "atomics")]timed-out
+#[cfg(feature = "temporal")]timeZone
 toArray
 #[cfg(feature = "date")]toDateString
 toExponential
@@ -454,6 +483,7 @@ toStringTag
 #[cfg(feature = "date")]toTimeString
 toUpperCase
 #[cfg(feature = "date")]toUTCString
+#[cfg(feature = "temporal")]toZonedDateTimeISO
 toWellFormed
 #[cfg(feature = "array-buffer")]transfer
 #[cfg(feature = "array-buffer")]transferToFixedLength
@@ -478,6 +508,7 @@ undefined
 unregister
 unscopables
 unshift
+#[cfg(feature = "temporal")]until
 URIError
 #[cfg(feature = "date")]UTC
 value
@@ -488,7 +519,9 @@ values
 #[cfg(feature = "weak-refs")]WeakMap
 #[cfg(feature = "weak-refs")]WeakRef
 #[cfg(feature = "weak-refs")]WeakSet
+#[cfg(feature = "temporal")]weeks
 with
 withResolvers
 writable
 #[cfg(feature = "atomics")]xor
+#[cfg(feature = "temporal")]years

nova_vm/src/ecmascript/abstract_operations/type_conversion.rs

@@ -1553,6 +1553,37 @@ pub(crate) fn try_to_index<'a>(
     js_result_into_try(validate_index(agent, integer, gc))
 }
 
+/// [14.5.1.1 ToIntegerIfIntegral ( argument )](https://tc39.es/proposal-temporal/#sec-tointegerifintegral)
+/// The abstract operation ToIntegerIfIntegral takes argument argument
+/// (an ECMAScript language value) and returns either a normal completion containing
+/// an integer or a throw completion.
+/// It converts argument to an integer representing its Number value,
+/// or throws a RangeError when that value is not integral.
+#[cfg(feature = "array-buffer")]
+pub(crate) fn to_integer_if_integral<'gc>(
+    agent: &mut Agent,
+    argument: Value,
+    mut gc: GcScope<'gc, '_>,
+) -> JsResult<'gc, Number<'gc>> {
+    let argument = argument.bind(gc.nogc());
+    // 1. Let number be ? ToNumber(argument).
+    let number = to_number(agent, argument.unbind(), gc.reborrow())
+        .unbind()?
+        .bind(gc.nogc());
+    // 2. If number is not an integral Number, throw a RangeError exception.
+    if !number.is_integer(agent) {
+        Err(agent.throw_exception_with_static_message(
+            ExceptionType::RangeError,
+            "Number must be integral",
+            gc.into_nogc(),
+        ))
+    } else {
+        // 3. Return ℝ(number).
+        // Ok(number.into_i64(agent)) // TODO: more performant
+        Ok(number.unbind())
+    }
+}
+
 /// Helper function to check if a `char` is trimmable.
 ///
 /// Copied from Boa JS engine. Source https://github.com/boa-dev/boa/blob/183e763c32710e4e3ea83ba762cf815b7a89cd1f/core/string/src/lib.rs#L51

nova_vm/src/ecmascript/builtins.rs

@@ -66,6 +66,8 @@ mod set;
 #[cfg(feature = "shared-array-buffer")]
 mod shared_array_buffer;
 mod structured_data;
+#[cfg(feature = "temporal")]
+mod temporal;
 mod text_processing;
 #[cfg(feature = "array-buffer")]
 mod typed_array;
@@ -112,6 +114,8 @@ pub use set::*;
 #[cfg(feature = "shared-array-buffer")]
 pub use shared_array_buffer::*;
 pub(crate) use structured_data::*;
+#[cfg(feature = "temporal")]
+pub use temporal::*;
 pub use text_processing::*;
 #[cfg(feature = "array-buffer")]
 pub use typed_array::*;

nova_vm/src/ecmascript/builtins/ordinary.rs

@@ -18,6 +18,8 @@ use std::{
 use crate::ecmascript::SharedDataViewRecord;
 #[cfg(feature = "array-buffer")]
 use crate::ecmascript::try_get_result_into_value;
+#[cfg(feature = "temporal")]
+use crate::ecmascript::{DurationHeapData, InstantRecord};
 use crate::{
     ecmascript::{
         Agent, ArgumentsList, BUILTIN_STRING_MEMORY, ExceptionType, Function, InternalMethods,
@@ -1651,6 +1653,10 @@ pub(crate) fn ordinary_object_create_with_intrinsics<'a>(
             .heap
             .create(ErrorHeapData::new(ExceptionType::SyntaxError, None, None))
             .into(),
+        #[cfg(feature = "temporal")]
+        ProtoIntrinsics::TemporalInstant => agent.heap.create(InstantRecord::default()).into(),
+        #[cfg(feature = "temporal")]
+        ProtoIntrinsics::TemporalDuration => agent.heap.create(DurationHeapData::default()).into(),
         ProtoIntrinsics::TypeError => agent
             .heap
             .create(ErrorHeapData::new(ExceptionType::TypeError, None, None))
@@ -2084,6 +2090,10 @@ fn get_intrinsic_constructor<'a>(
         ProtoIntrinsics::WeakRef => Some(intrinsics.weak_ref().into()),
         #[cfg(feature = "weak-refs")]
         ProtoIntrinsics::WeakSet => Some(intrinsics.weak_set().into()),
+        #[cfg(feature = "temporal")]
+        ProtoIntrinsics::TemporalInstant => Some(intrinsics.temporal_instant().into()),
+        #[cfg(feature = "temporal")]
+        ProtoIntrinsics::TemporalDuration => Some(intrinsics.temporal_duration().into()),
     }
 }