Gemini polishing #51
Merged
Gemini polishing #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| console.dir(modelInfo) | ||
| console.dir(modelId) | ||
| const deepseekReasoner = modelId.includes("deepseek-reasoner") | ||
| const ark = modelUrl.includes(".volces.com") |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 9 months ago
To fix the problem, we need to parse the URL and check the host value instead of using a substring check. This ensures that the check is accurate and cannot be bypassed by embedding the allowed host in an unexpected location within the URL.
- Parse the URL using the
URLconstructor to extract the host. - Check if the host matches the allowed host or its subdomains.
- Replace the substring check with the new host validation logic.
Suggested changeset
1
src/api/providers/pearai/pearaiGeneric.ts
| @@ -73,3 +73,10 @@ | ||
| const deepseekReasoner = modelId.includes("deepseek-reasoner") | ||
| const ark = modelUrl.includes(".volces.com") | ||
| let ark = false | ||
| try { | ||
| const urlHost = new URL(modelUrl).host | ||
| ark = urlHost === "volces.com" || urlHost.endsWith(".volces.com") | ||
| } catch (error) { | ||
| // Handle invalid URL | ||
| ark = false | ||
| } | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add robustness and everything is synced with server now