Documentation for LD matrix methods#3416
Conversation
271bcaa to
e2f50d6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3416 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 37 37
Lines 32153 32153
Branches 5143 5143
=======================================
Hits 29556 29556
Misses 2264 2264
Partials 333 333
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jeromekelleher
left a comment
There was a problem hiding this comment.
I've had a quick read through and generally looks great. I've spotted a few typos and left a few take-it-or-leave-it comments.
I haven't thought through the details at all through, and I think it needs a careful review from @petrelharp for that.
|
Thanks so much for the quick review, @jeromekelleher. I agree with your suggestions and will fix things up accordingly. |
e2f50d6 to
7e2b62a
Compare
|
I think this will also need a changelog entry, since adding documentation will announce that this API is now public. Does that happen here or in a later part of the release pipeline? |
|
That could happen here! |
|
We can add to the changelog here or not, whichever is easier. We do need a review from you though @petrelharp as I'm not on top of the stats details. |
|
I've created a milestone for version 1.1, which will basically be this new LD API plus the new metadata codec. Would be good to get it shipped in the next week or so if possible. |
7e2b62a to
bae4065
Compare
See #3353.
This largely pulls material from an existing, open PR to complete minimal documentation for the LD matrix methods currently available in tskit. I've made edits for clarity from the original PR, and removed some material that is possibly confusing or more information than needed for a user.