Skip to content

Documentation for LD matrix methods#3416

Open
apragsdale wants to merge 5 commits intotskit-dev:mainfrom
apragsdale:ld_matrix_docs
Open

Documentation for LD matrix methods#3416
apragsdale wants to merge 5 commits intotskit-dev:mainfrom
apragsdale:ld_matrix_docs

Conversation

@apragsdale
Copy link

See #3353.

This largely pulls material from an existing, open PR to complete minimal documentation for the LD matrix methods currently available in tskit. I've made edits for clarity from the original PR, and removed some material that is possibly confusing or more information than needed for a user.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.92%. Comparing base (1835ea3) to head (bae4065).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3416   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          37       37           
  Lines       32153    32153           
  Branches     5143     5143           
=======================================
  Hits        29556    29556           
  Misses       2264     2264           
  Partials      333      333           
Flag Coverage Δ
C 82.70% <ø> (ø)
c-python 77.34% <ø> (ø)
python-tests 96.40% <ø> (ø)
python-tests-no-jit 33.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Python API 98.69% <ø> (ø)
Python C interface 91.23% <ø> (ø)
C library 88.86% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a quick read through and generally looks great. I've spotted a few typos and left a few take-it-or-leave-it comments.

I haven't thought through the details at all through, and I think it needs a careful review from @petrelharp for that.

@apragsdale
Copy link
Author

Thanks so much for the quick review, @jeromekelleher. I agree with your suggestions and will fix things up accordingly.

@lkirk
Copy link
Contributor

lkirk commented Mar 9, 2026

I think this will also need a changelog entry, since adding documentation will announce that this API is now public. Does that happen here or in a later part of the release pipeline?

@petrelharp
Copy link
Contributor

That could happen here!

@jeromekelleher
Copy link
Member

We can add to the changelog here or not, whichever is easier. We do need a review from you though @petrelharp as I'm not on top of the stats details.

@jeromekelleher jeromekelleher added this to the 1.1.0 milestone Mar 10, 2026
@jeromekelleher
Copy link
Member

I've created a milestone for version 1.1, which will basically be this new LD API plus the new metadata codec. Would be good to get it shipped in the next week or so if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants