Open
Conversation
petrelharp
commented
Mar 12, 2026
| To test out changes to the *code*, you can change to the `python/` subdirectory, | ||
| and run `make` to compile the C code. | ||
| If you then execute `python` from this subdirectory (and only this one!), | ||
| If you then execute python commands from this subdirectory (and only this one!), |
Contributor
Author
There was a problem hiding this comment.
you can't run python; you can only run uv run python etc
petrelharp
commented
Mar 12, 2026
| To install the hook: | ||
|
|
||
| ```bash | ||
| $ uv run prek install |
Contributor
Author
There was a problem hiding this comment.
this was already said above
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3428 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 37 37
Lines 32153 32153
Branches 5143 5143
=======================================
Hits 29556 29556
Misses 2264 2264
Partials 333 333
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
petrelharp
commented
Mar 12, 2026
| Note that this guide covers the most complex case of adding a new function to both | ||
| the C and Python APIs. | ||
|
|
||
| 0. Draft a docstring for your function, that describes exactly what the function |
Contributor
Author
There was a problem hiding this comment.
since I'm not building locally I haven't checked if we can actually start a list at zero. but I think this should be first, not last?
Member
|
Hmm - what version of doxygen are you using? I've got |
jeromekelleher
approved these changes
Mar 12, 2026
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
Changes LGTM, but we should get to the bottom of the doxygen issue (which is annoying!).
| Note that this guide covers the most complex case of adding a new function to both | ||
| the C and Python APIs. | ||
|
|
||
| 0. Draft a docstring for your function, that describes exactly what the function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I"ve gone through the dev docs and done a lot of the things in them. They are great, thanks @jeromekelleher. I have only minor edits.
However: maybe they need something else, since the docs don't build for me locally? I get