Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
damacros to use.instead of->.The
damacros should be able to be used on values and pointers (which they currently are) using:arena_da_append(a, da, item)where da is a pointer, which expands to code using(da)->capacityandarena_da_append(a, &da, item)where da is a value, which expands to code using(&da)->capacity(da)->capacityis good(&da)->capacityis not good because it is usually optimised toda.capacity, but this is not guaranteed.But, in this PR, the calling code would use:
arena_da_append(a, *da, item)where da is a pointer, which expands to code using(*da).capacityandarena_da_append(a, da, item)where da is a value, which expands to code using(da).capacity(*da).capacityis good because it is equivalent toda->capacity(da).capacityis good