[stacktrace] pull file/line/name out of stack traces #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous change just pulled out the entire stack trace from the log message. This change processes the stack traces to pull out the file/line/name data. Note: I haven't standardized an order for the call sites in a trace, Java goes one way and Python goes the other. Sigh... Files: * debugAdapter.ts: Add exceptionTrace field to LogMapping. * lib.rs: The find_source_file_statements() can now match multiple source files since find_file() can now match multiple files. Add exception_trace to LogMapping and to_exception_trace() to StackTrace. * main.rs: Change the meaning of --count to be the number of messages since we don't necessarily know how many lines are in a message. * source_hier.rs: Since the Java stack trace code can only figure out the package and class name. The find_file() method has been changed to allow searching the tree for a partial path. For example, searching for "org/example/Main.java" will walk the entire tree looking for a match of that path. It will then return all possible matches of that path.
This was bugging me... missed needing to use into_iter() for the result of find_file()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous change just pulled out the entire stack trace from the log message. This change processes the stack traces to pull out the file/line/name
data.
Note: I haven't standardized an order for the call sites in a trace, Java goes one way and Python goes the other. Sigh...
Files: