scoryst:0.1.2#4887
Conversation
bernsteining
temporarily deployed
to
Package Check
GitHub Actions
Inactive
elegaanz
left a comment
elegaanz
left a comment
There was a problem hiding this comment.
Thank you for the update. A few comments and tips:
| "CMME", | ||
| ] | ||
| categories = ["visualization", "integration"] | ||
| compiler = "0.14.2" |
There was a problem hiding this comment.
The compiler field is a minimum version, so unless you explicitly require the latest patch release, changing it to 0.14.0 will allow using this package with a slightly outdated compiler.
| @@ -0,0 +1,112 @@ | |||
|  | |||
There was a problem hiding this comment.
For info, you can have images that automatically change depending on the theme, both on Typst Universe and GitHub. The pattern is documented here.
There was a problem hiding this comment.
Are URLs handled correctly ?
<picture>
<source media="(prefers-color-scheme: dark)" srcset="https://github.com/bernsteining/scoryst/blob/v0.1.2/test/logo.svg">
<img alt="logo" src="https://github.com/bernsteining/scoryst/blob/v0.1.1/test/logo.svg">
</picture>
Doesn't render correctly in my markdown preview in VSCode.
There was a problem hiding this comment.
You should the "raw" URL: https://raw.githubusercontent.com/bernsteining/scoryst/refs/tags/v0.1.1/test/logo.svg for example. You obtain it with the "Raw" button in the top right corner of the file on GitHub.
|
|
||
| Returns the number of pages for the given music data. | ||
|
|
||
| ### Verovio Options |
There was a problem hiding this comment.
I didn't notice in previous reviews I think, but kebab-case is more common as a naming convention than camelCase in the Typst ecosystem. I think it would be nice to support kebab-case variants of the options and to encourage people to use that instead, to make the package more idiomatic. But the API is up to you in the end, so feel free to dismiss my suggestion if you think it's better to have a perfect mapping between the Typst API and the original Verovio options.
There was a problem hiding this comment.
Okay I added kebab-case support for the Verovio options, and camel case is still also supported.
bernsteining
temporarily deployed
to
Package Check
GitHub Actions
Inactive
bernsteining
temporarily deployed
to
Package Check
GitHub Actions
Inactive
2 participants
I am submitting
0.1.2 Changelog
wasm-optflagsNB: in README.md the logo links to the v0.1.1 one on purpose. the v0.1.2 is white to handle dark theme on github, and typst universe I want it to remain black.