preserve errno/GetLastError() in bsd_close_socket() so as not to thash errors raised by listen() etc.#254
Open
georg-emg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an error occurrs in many operations, the function
bsd_close_socket()is called to close the socket before returning an error code. Unfortunately, the call toclose()/closesocket()insidebsd_close_socket()will overwrite the value oferrno/GetLastError(), making it difficult to determine the original error. For example, if I try to listen on a port that is already in use, the error (EADDRINUSE) get thrashed by the call tobsd_close_socket(), making it pretty much impossible to output/log the correct error.This small PR saves the value of
errno/GetLastError()insidebsd_close_coket()before callingclose()/closesocket(), and restores it afterwards. This allows the error raised by the actual action (e.g.listen()) to be read by the caller.NOTE: We submitted a pull request for this some time ago ( #196), but I think something went wrong there. I rebased the change on the latest revision and am creating a new PR. #196 is defunct and can be closed. Sorry about that.