Add TestScope#120
Merged
SokolAndrey merged 1 commit intouber-java:masterfrom Dec 18, 2023
zmanji:add-test-scope
Merged
Conversation
|
|
SokolAndrey
reviewed
Dec 18, 2023
SokolAndrey
reviewed
Dec 18, 2023
Merged
SokolAndrey
pushed a commit
that referenced
this pull request
Jan 4, 2024
#120 has a bug where the `Snapshot` only includes the subscopes and not the metrics on the current scope. This fixes the `snapshot` method to include metrics on the current scope as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit plucks select changes from #69 and #43 to bring uber-java/tally on par with uber-go/tally.
It adds a
TestScopeclass which allows users of the library to get aSnapshotof all the metrics emitted by the scope. Users can then assert if certain metrics were created on the scope.In order to implement this a
NullStatsReporterwas added and aTestScopeinterface was added that exposesthe
snapshotmethod. Thesnapshotmethod was also changed to ensure that a subscope's tags were includedwhen creating the snapshot. Also the
putAllmethod of theImmutableMapwas made null safe. AlsoScopeKeywas made null safe.
TestScopeTestshows how theTestScopecan be used.