Skip to content

docs: add Learn guide for error handling and loader error propagation#152

Merged
uhyo merged 4 commits intomasterfrom
copilot/add-error-handling-page
Mar 12, 2026
Merged

docs: add Learn guide for error handling and loader error propagation#152
uhyo merged 4 commits intomasterfrom
copilot/add-error-handling-page

Conversation

Copy link
Contributor

Copilot AI commented Mar 12, 2026

  • Review the new PR comment requesting a CI fix
  • Inspect recent GitHub Actions workflow runs and failing job logs for this branch
  • Reproduce the CI failure locally and identify the smallest viable fix
  • Apply the targeted fix and rerun focused validation
  • Run final review and security checks
  • Reply to the PR comment with the fix commit and screenshot

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Co-authored-by: uhyo <748348+uhyo@users.noreply.github.com>
Copilot AI changed the title [WIP] [UHYO-145] Add new Learn page for Error Handling docs: add Learn guide for error handling and loader error propagation Mar 12, 2026
Copilot finished work on behalf of uhyo March 12, 2026 14:03
<code>entryId</code> comes from the Navigation API&rsquo;s current
history entry. It changes when the router moves to a different entry,
so using it in <code>resetKeys</code> lets the boundary recover when
the user clicks another link, goes back/forward, or triggers a reload.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Statement on reload is inaccurate. Reload doesn't change entry ID.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 2430d28. I removed the reload wording and now describe entryId only in terms of moving to a different history entry. Screenshot: /tmp/playwright-logs/learn-error-handling-page-review-fixes.png.

Comment on lines +87 to +90
<strong>Synchronous loader throws</strong> &mdash; the router catches
the error while preparing the matched route and re-throws it during
that route&rsquo;s render. The nearest Error Boundary above the route
catches it.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be written more from user perspective. Caching is implementation detail.

Let's say that sync loader errors are thrown from that route's Outlet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 2430d28. I rewrote the sync loader bullet to describe the error as being thrown from that route’s <Outlet /> when React renders it. Screenshot: /tmp/playwright-logs/learn-error-handling-page-review-fixes.png.

Co-authored-by: uhyo <748348+uhyo@users.noreply.github.com>
Copilot finished work on behalf of uhyo March 12, 2026 15:11
@uhyo
Copy link
Owner

uhyo commented Mar 12, 2026

@copilot please fix CI failure.

Co-authored-by: uhyo <748348+uhyo@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 12, 2026

@copilot please fix CI failure.

Fixed in 14b3fcb. I checked the failing CI run and it was failing only at prettier --check . for packages/docs/src/pages/LearnErrorHandlingPage.tsx, so I applied the minimal formatting-only fix and revalidated with pnpm format:check, docs build/typecheck, and lint. Screenshot: https://github.com/user-attachments/assets/fc7fcd7b-6537-459c-94cc-2065b60d3fd1

Copilot finished work on behalf of uhyo March 12, 2026 15:34
@uhyo uhyo marked this pull request as ready for review March 12, 2026 15:37
@uhyo uhyo merged commit 73c6f60 into master Mar 12, 2026
1 check passed
@uhyo uhyo deleted the copilot/add-error-handling-page branch March 12, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants