Open
Conversation
rchung95
commented
Oct 21, 2016
rchung95
commented
Owner
|
Thanks for the PR! For some reason, this look a bit different on my system than on yours
|
Author
|
I retested it and notice that. I do apologize for not noticing it sooner. I have added another commit, and ran the test. I have changed the settings and this one is a lot better. |
una
reviewed
Nov 3, 2016
source/scss/stinson.scss
Outdated
| // } | ||
| @mixin stinson($filters...) { | ||
| @include filter-base; | ||
| filter: brightness(1.25) contrast(0.8) saturate(0.95) grayscale(0.05) sepia(0.05) $filters; |
Owner
There was a problem hiding this comment.
Thanks for this PR! I did some adjustments, what do you think of using filter: brightness(1.15) contrast(.8) saturate(.85) sepia(.1);
and altering the ::after pseudo element to be:
background: rgba(240, 149, 128, .2);
mix-blend-mode: soft-light;
Before:
After -- I think it looks a little bit closer (tiny bit lighter and warmer):
Owner
|
I made similar comments on #251 -- there are a few PRs on this filter right now, just waiting on the first one to adjust their filter |
Closed
Author
|
Added the requested changes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.