Added possibility to give opts via symbols instead of string as key for the opts hash#365
Open
AlbinOS wants to merge 3 commits intoupserve:masterfrom
Open
Added possibility to give opts via symbols instead of string as key for the opts hash#365AlbinOS wants to merge 3 commits intoupserve:masterfrom
AlbinOS wants to merge 3 commits intoupserve:masterfrom
Conversation
Contributor
Author
|
Do you have any idea why is the build of my PR failing ? I ran all tests locally and everything passed normally. |
Contributor
|
Any reason you gave preference to the symbols approach instead of strings approach? Since strings were previously default, probably a good idea to keep that first. |
Contributor
Author
|
@tlunter, not really, it's just an habit I guess. I'll modify this PR according to your remark. Thanks for the feedback ! |
Contributor
Author
|
@tlunter, it should be ok now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for #360.
I started writing test but it felt wrong as I was only duplicating existing test and calling methods with ':key' instead of '"key"'. Is it ok for you ? Or do you have a better idea to test theses changes in a smart way ?