Open
Conversation
Author
|
A TODO on this is to figure out how to use travis CI to do the swarm tests or just mock the docker daemon responses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to integrate docker-machine to ease local testing of docker-api. It does this by using a (very) lightweight gem called 'docker_machine' to talk to the
docker-machinecli, sets up a docker-machine VM, evaluates the VMs docker config bits into the runtime'sENV, and runs the test suite against that VM. This has been tested to be working withbundle exec rake DOCKER_VERSION=1.11.1.I am unsure if this is the best approach to make docker-api talk to the docker-machine and I am open to other approaches if they would fit better into how docker-api works.
I would like this to be merged sooner rather than later so that I may use it for my docker 1.12.0 updates I am doing for docker-api.
Thanks in advance and please let me know any questions you may have.