Handle exclusions when ignoring files#541
Open
ghostsquad wants to merge 1 commit intoupserve:masterfrom
ghostsquad:bugfix/484-dont-ignore-dockerfile
Open
Handle exclusions when ignoring files#541ghostsquad wants to merge 1 commit intoupserve:masterfrom ghostsquad:bugfix/484-dont-ignore-dockerfile
ghostsquad wants to merge 1 commit intoupserve:masterfrom
ghostsquad:bugfix/484-dont-ignore-dockerfile
Conversation
Always exclude Dockerfile and .dockerignore from being ignored. https://docs.docker.com/engine/reference/builder/#dockerignore-file > You can even use the .dockerignore file to exclude the Dockerfile and .dockerignore files. > These files are still sent to the daemon because it needs them to do its job. > But the ADD and COPY instructions do not copy them to the image. resolves #484
|
@tlunter Any chance to get it merged in? |
Contributor
|
What does this PR need in order to be accepted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always exclude Dockerfile and .dockerignore from being ignored.
https://docs.docker.com/engine/reference/builder/#dockerignore-file
resolves #484