Open
Conversation
Contributor
|
Looks good, you'll need to update the documentation here: https://github.com/urbanairship/ruby-library/tree/main/docs |
lloydwatkin
reviewed
Dec 14, 2021
| end | ||
|
|
||
| def subscribe(list_id, email_addresses) | ||
| subscribe_payload = payload(SUBSCRIBE, list_id, email_addresses) |
Contributor
There was a problem hiding this comment.
Do you need to raise an error if list_id or email_addresses aren't supplied:
fail TypeError, 'list_id musy be provided' unless list_id.is_a? String
Author
There was a problem hiding this comment.
Thank you, I will take care of that!
jo-wojtowicz
force-pushed
the
subscription-lists
branch
from
e80de55 to
a024f60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request connects to the issue https://github.com/OLIOEX/community-team/issues/882.
We would like to be able to subscribe users to Airship's subscriptions lists. This operation is not currently supported by the Airship's Ruby Library, so we decided to add it in our fork.
https://docs.airship.com/api/ua/#operation-api-channels-subscription_lists-post.