feat: ShellComplete for fish #2256
Open
+51
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it
Implement ShellComplete support for fish shell. I was a bit surprised
to find that this wasn't supported after implementing ShellComplete by
following [the
documentation](https://cli.urfave.org/v3/examples/completions/customizations/]
for customizations.
Which issue(s) this PR fixes
(REQUIRED)
I saw there was a draft PR #2144, but I think this implementation is a bit more
focused.
Testing
In addition to the unit tests, I've tested it in my project hei by using a replace and confirming that fish dynamic completion works for
the
updateandgen switchcommands.Release Notes
ShellComplete support for fish.