generateRandomToken improvement.#1176
Open
michaellrowley wants to merge 3 commits intouserfrosting:hotfixfrom
michaellrowley:security-patch
Open
generateRandomToken improvement.#1176michaellrowley wants to merge 3 commits intouserfrosting:hotfixfrom michaellrowley:security-patch
michaellrowley wants to merge 3 commits intouserfrosting:hotfixfrom
michaellrowley:security-patch
Conversation
The MD5 call altogether has been switched out for the hexadecimal representation of 16 CSRNG-generated bytes. See [this](https://huntr.dev/bounties/5cc92fbb-5a63-4693-aa01-775692fb137e/)
Codecov Report
@@ Coverage Diff @@
## hotfix #1176 +/- ##
============================================
- Coverage 70.68% 70.68% -0.01%
Complexity 1984 1984
============================================
Files 173 173
Lines 6911 6910 -1
============================================
- Hits 4885 4884 -1
Misses 2026 2026
Continue to review full report at Codecov.
|
Member
|
N.B.: This will need to be properly (manually) tested to make sure the existing token (if any) are not impacted and Captcha still properly working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MD5 call altogether has been switched out for the hexadecimal representation of 16 CSRNG-generated bytes (the same amount at MD5 produces).
See this.