Code style: don't patch expressions/statements with preprocessor#1243
Draft
elizarov wants to merge 1 commit into
Draft
Code style: don't patch expressions/statements with preprocessor#1243elizarov wants to merge 1 commit into
elizarov wants to merge 1 commit into
Conversation
5df8437 to
9b54d57
Compare
9b54d57 to
9e51b55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request establishes the following code style discipline: conditional directives are not allowed below the supported item boundary, such as inside an expression, declaration, or statement header.
Conditional compilation is allowed:
=in assignment statements, alias declarations, and concept definitions.This discipline keeps the code easier to read for humans and easier to parse, highlight, and format with tools. Code-analysis tools do not need to reason about partial expressions or statement headers across all conditional-compilation branches.
P.S. There's an ongoing work in https://github.com/elizarov/strictfmt to implement a rule-based source code formatter that correctly parses and formats all the source code when these restrictions are met.