fix universal: fix random generator initialization in C++23#1245
Open
emikg777 wants to merge 1 commit into
Open
fix universal: fix random generator initialization in C++23#1245emikg777 wants to merge 1 commit into
emikg777 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utils::impl::RandomImplinitializedstd::mt19937viaAsLvalue(impl::MakeSeedSeq()).This fails to compile in C++23, because returning the rvalue-reference parameter from
AsLvalueis affected by the C++23 implicit move rules from P2266R3. As a result, the returned expression may no longer be treated as a non-const lvalue reference, while the seed-sequence constructor of the generator expects a non-const lvalue seed sequence.The error is (gcc 15.2.0):
This change removes the
AsLvaluehelper and initializes the generator from a localstd::seed_seqobject instead. The local object stays alive for the duration of the generator construction, and no reference to a temporary is returned.Testing:
CMAKE_CXX_STANDARD=23.userver-universal-unittest.userver-universal-unittestrun: 1671/1672 tests passed. The only failure wasLogFilepath.UserverCroppedCorrectly, which appears to be path-layout-sensitive when userver is built as a CPM dependency under_deps/userver-src.