Skip to content

Expose uses in TModels produced by Rascal typechecker #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sungshik wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −1
Draft

Expose uses in TModels produced by Rascal typechecker #2803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09b016d
Add test (currently fails) for issue that `tm.uses` is empty in TMode…
sungshik Jun 15, 2026
e637cb7
Fix issue that `tm.uses` was empty in TModels produced by the Rascal …
sungshik Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/org/rascalmpl/compiler/lang/rascalcore/check/Import.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,7 @@ ModuleStatus doSaveModule(set[MODID] component, map[MODID,set[MODID]] m_imports,
}
};

m1.uses = [u | Use u <- tm.uses, u.occ in m1.useDef<0>];
m1.defines = toSet(defs);

m1.definitions = ( def.defined : def | Define def <- m1.defines); // TODO this is derived info, can we derive it later?
Expand Down
3 changes: 3 additions & 0 deletions src/org/rascalmpl/compiler/lang/rascalcore/check/tests/StaticTestingUtils.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,9 @@ bool validateUseDefs(str moduleName, map[str, tuple[int, set[int]]] defuses, Mod
if(!occ[u]?){
throw "Missing use <u> for <v>";
}
if(!any(use <- tm.uses, occ[u] == use.occ)){
throw "Missing `Use` value for use <u> of <v>";
}
potentialDefs = foundUseDefs[occ[u]];
if(isEmpty(potentialDefs) || !any(d <- potentialDefs, occ[def] == (tm.logical2physical[d] ? d))){
throw "Missing def for use <u> of <v>";
Expand Down
12 changes: 11 additions & 1 deletion src/org/rascalmpl/compiler/lang/rascalcore/check/tests/UseDefTests.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,14 @@ test bool overloadedSyntaxField(){
return useDefOK(mtext, ("c": <0, {2}>)) // check uses of first declaration of c
&& useDefOK(mtext, ("c": <1, {3}>)) // check uses of first declaration of c
;
}
}

test bool issue2165() =
useDefOK("module Issue2165
int f(int i) {
int x = 2;
return i * x;
}
void main() {
f(5);
}", ("x": <0, {1}>, "i": <0, {1}>, "f": <0, {1}>));
Loading