Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds developer tooling (Dev Container + Makefile) and expands the site’s members roster, including a new “Associate Director of Communications” role.
Changes:
- Added a VS Code Dev Container and a Makefile to streamline local Jekyll development.
- Updated site configuration and README for the new workflow.
- Added new member profile pages and updated leadership roles.
Reviewed changes
Copilot reviewed 16 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
members.md |
Adds “Associate Director of Communications” to the rendered role sections. |
assets/img/member_photos/Wang_Bao.png |
Adds member headshot asset for Bao Wang. |
assets/img/member_photos/Venkatraman_Raghav.png |
Adds member headshot asset for Raghav Venkatraman. |
assets/img/member_photos/Tao_Guanhong.png |
Adds member headshot asset for Guanhong Tao. |
_members/new_members/Wang-Bao.md |
Adds Bao Wang profile. |
_members/new_members/Venkatraman-Raghav.md |
Adds Raghav Venkatraman profile. |
_members/new_members/Tao-Guanhong.md |
Adds Guanhong Tao profile. |
_members/new_members/Rosen-Paul.md |
Adds Paul Rosen profile. |
_members/new_members/Narayan-Akil.md |
Adds Akil Narayan profile. |
_members/new_members/Modenesi-Bernardo.md |
Adds Bernardo Modenesi profile. |
_members/new_members/Miles-Chris.md |
Adds Chris Miles profile. |
_members/new_members/Marino-Kenneth.md |
Adds Kenneth Marino profile. |
_members/new_members/Fariha-Anna.md |
Adds Anna Fariha profile. |
_members/leadership/Vega-Yon-George.md |
Updates George Vega Yon’s title and role to “Associate Director of Communications”. |
_members/leadership/Rezig-ElKindi.md |
Adds El Kindi Rezig profile. |
_config.yml |
Sets UTF-8 encoding and disables the default github-pages theme. |
README.md |
Documents Makefile-based dev workflow. |
Makefile |
Adds common dev targets (setup/serve/build/clean/help). |
.devcontainer/devcontainer.json |
Adds Dev Container definition for Ruby/Jekyll work. |
.devcontainer/Containerfile |
Defines the container image build steps and Ruby/Jekyll tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+9
| "dockerfile": "Containerfile" | ||
| }, | ||
| "postCreateCommand": "bundle install", | ||
| "forwardPorts": [4000], | ||
| "customizations": { | ||
| "vscode": { |
There was a problem hiding this comment.
In devcontainer.json, the Dev Container spec expects build.dockerFile (capital F). Using dockerfile may be ignored by VS Code/devcontainer CLI, causing the container build to fail. Rename the key accordingly.
Suggested change
| "dockerfile": "Containerfile" | |
| }, | |
| "postCreateCommand": "bundle install", | |
| "forwardPorts": [4000], | |
| "customizations": { | |
| "vscode": { | |
| "dockerFile": "Containerfile" | |
| }, | |
| "postCreateCommand": "bundle install", | |
| "forwardPorts": [4000], | |
| "customizations": { | |
| "vscode": { |
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a development container setup for the project, adds a Makefile for easier development workflows, updates the project configuration, and expands the members directory with several new profiles and role adjustments. The most significant changes are grouped below:
Development Environment Setup:
.devcontainer/Containerfileto define a Docker-based development environment with Ruby, Jekyll, Bundler, and essential dependencies..devcontainer/devcontainer.jsonto configure VS Code Dev Containers, including recommended extensions and port forwarding for Jekyll.Developer Workflow Improvements:
Makefilewith common development commands (setup,serve,build,clean, andhelp) to streamline local development and documentation.README.mdto reference the new Makefile commands for easier onboarding.Project Configuration:
_config.ymlto explicitly set UTF-8 encoding and disable the default GitHub Pages theme.Members Directory Expansion and Updates:
_members/new_members/for Anna Fariha, Kenneth Marino, Chris Miles, Bernardo Modenesi, Akil Narayan, Paul Rosen, Guanhong Tao, Raghav Venkatraman, and Bao Wang, each with detailed bios and roles. [1] [2] [3] [4] [5] [6] [7] [8] [9]members.mdto include the new "Associate Director of Communications" role in the displayed roles list.