-
Notifications
You must be signed in to change notification settings - Fork 55
Add skipDuplicates() scope guard to createDocuments #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
premtsd-code
wants to merge
26
commits into
main
Choose a base branch
from
csv-import-upsert-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+769
−37
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
60f1ff1
Add ignore param to createDocuments for silent duplicate handling
premtsd-code bee42d4
Add e2e tests for createDocuments ignore mode
premtsd-code 93a9136
Fix Mongo adapter ignore mode: pass ignoreDuplicates to client and fi…
premtsd-code 2906dda
Revert "Fix Mongo adapter ignore mode: pass ignoreDuplicates to clien…
premtsd-code 63d9902
Replace ignore param with skipDuplicates scope guard
premtsd-code b0a8392
Push skipDuplicates scope guard down to Adapter layer
premtsd-code d8f647c
Refactor: extract helpers and collapse conditional wraps
premtsd-code c88c6ac
fix: guard buildUidTenantLookup against empty UID set
premtsd-code 16849fe
Add e2e tests for skipDuplicates edge cases
premtsd-code c6d566e
SQL adapter: remove redundant skipDuplicates pre-filter
premtsd-code fd37b69
Mongo adapter: use upsertWithCounts for race-safe accurate counts
premtsd-code a24358c
Merge remote-tracking branch 'origin/main' into csv-import-upsert-v2
premtsd-code 3b783af
Revert "SQL adapter: remove redundant skipDuplicates pre-filter"
premtsd-code 3a483f2
Mirror: forward only docs the source actually inserted
premtsd-code eb99cf1
skipDuplicates: simplify by moving pre-filter to orchestrator only
premtsd-code 89e4cf8
skipDuplicates: drop deferred-relationships, inline pre-filter, tight…
premtsd-code 41704eb
Address Jake's review on PR #852
premtsd-code e9e5e76
Mirror::createDocuments: bound skipDuplicates capture to O($batchSize)
premtsd-code ae929db
Restore per-tenant grouping for batch existing-doc lookups in tenantP…
premtsd-code 431d378
skipDuplicates: drop pre-filter, rely on adapter-level dedup
premtsd-code 0fd7c33
skipDuplicates: drop intra-batch dedup, trim verbose test comments
premtsd-code 9baaa04
Group skipDuplicates / getInsert* into their logical clusters
premtsd-code 3c85013
Mirror::createDocuments: re-fetch source after skipDuplicates insert
premtsd-code 934ec04
Mirror::createDocuments: pre-filter existing ids + unify skip/non-ski…
premtsd-code fa0e373
Chunk id-lookup queries to respect RELATION_QUERY_CHUNK_SIZE
premtsd-code 52b189b
Chunk id lookups by \$this->maxQueryValues, not RELATION_QUERY_CHUNK_…
premtsd-code File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.